chrome/test/chromedriver/net/websocket.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/net/websocket.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/net/websocket.cc

diff --git a/chrome/test/chromedriver/net/websocket.cc b/chrome/test/chromedriver/net/websocket.cc

index a829675bcf6c6040868ebea19baedb45b23eeb61..3f43f483784bcf5f666b9535fee49b5dec47a7db 100644

--- a/chrome/test/chromedriver/net/websocket.cc

+++ b/chrome/test/chromedriver/net/websocket.cc

@@ -29,6 +29,7 @@

#include "net/base/sys_addrinfo.h"

#include "net/http/http_response_headers.h"

#include "net/http/http_util.h"

+#include "net/log/net_log_source.h"

#include "net/websockets/websocket_frame.h"

#if defined(OS_WIN)

@@ -90,7 +91,7 @@ void WebSocket::Connect(const net::CompletionCallback& callback) {

VLOG(0) << "resolved " << url_.HostNoBrackets() << " to " << json;

}

- net::NetLog::Source source;

+ net::NetLogSource source;

socket_.reset(new net::TCPClientSocket(addresses, NULL, NULL, source));

state_ = CONNECTING;