chrome/test/chromedriver/net/port_server.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/net/port_server.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/net/port_server.cc

diff --git a/chrome/test/chromedriver/net/port_server.cc b/chrome/test/chromedriver/net/port_server.cc

index 82922e319596ce0879a8bc2e801bdcbba789e2a7..dc35d06327b9e72d5ead08a3975105830367db68 100644

--- a/chrome/test/chromedriver/net/port_server.cc

+++ b/chrome/test/chromedriver/net/port_server.cc

@@ -20,7 +20,7 @@

#include "net/base/ip_address.h"

#include "net/base/net_errors.h"

#include "net/base/sys_addrinfo.h"

-#include "net/log/net_log.h"

+#include "net/log/net_log_source.h"

#include "net/socket/tcp_server_socket.h"

#if defined(OS_LINUX)

@@ -163,7 +163,7 @@ uint16_t PortManager::FindAvailablePort() const {

if (taken_.count(try_port_uint16))

continue;

- net::NetLog::Source source;

+ net::NetLogSource source;

net::TCPServerSocket sock(NULL, source);

if (sock.Listen(

net::IPEndPoint(net::IPAddress::IPv4Localhost(), try_port_uint16),