chrome/browser/extensions/api/socket/mock_tcp_client_socket.h - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/socket/mock_tcp_client_socket.h

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/socket/mock_tcp_client_socket.h

diff --git a/chrome/browser/extensions/api/socket/mock_tcp_client_socket.h b/chrome/browser/extensions/api/socket/mock_tcp_client_socket.h

index 2ae5e9cefbfaf39c0c929b55364a0ab3687dde27..595d268523409e3634ab1c6655bed9faafba5a5e 100644

--- a/chrome/browser/extensions/api/socket/mock_tcp_client_socket.h

+++ b/chrome/browser/extensions/api/socket/mock_tcp_client_socket.h

@@ -5,6 +5,8 @@

#ifndef CHROME_BROWSER_EXTENSIONS_API_SOCKET_MOCK_TCP_CLIENT_SOCKET_H_

#define CHROME_BROWSER_EXTENSIONS_API_SOCKET_MOCK_TCP_CLIENT_SOCKET_H_

+#include "net/log/net_log_source.h"

+#include "net/log/net_log_with_source.h"

#include "net/socket/tcp_client_socket.h"

#include "testing/gmock/include/gmock/gmock.h"

@@ -51,7 +53,7 @@ MockTCPClientSocket::MockTCPClientSocket()

: TCPClientSocket(net::AddressList(),

nullptr,

- net::NetLog::Source()) {}

+ net::NetLogSource()) {}

MockTCPClientSocket::~MockTCPClientSocket() {}

} // namespace extensions