chrome/browser/devtools/device/port_forwarding_controller.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/port_forwarding_controller.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/device/port_forwarding_controller.cc

diff --git a/chrome/browser/devtools/device/port_forwarding_controller.cc b/chrome/browser/devtools/device/port_forwarding_controller.cc

index dcae852ebffeeaeb1f81b367c5bb4a750e35801b..19ca9cd88bb53b5d9e5860c88929b6ae36c5b289 100644

--- a/chrome/browser/devtools/device/port_forwarding_controller.cc

+++ b/chrome/browser/devtools/device/port_forwarding_controller.cc

@@ -28,6 +28,8 @@

#include "net/base/io_buffer.h"

#include "net/base/net_errors.h"

#include "net/dns/host_resolver.h"

+#include "net/log/net_log_source.h"

+#include "net/log/net_log_with_source.h"

#include "net/socket/tcp_client_socket.h"

using content::BrowserThread;

@@ -81,7 +83,7 @@ class SocketTunnel : public base::NonThreadSafe {

}

host_socket_.reset(new net::TCPClientSocket(address_list_, nullptr, nullptr,

- net::NetLog::Source()));

+ net::NetLogSource()));

result = host_socket_->Connect(base::Bind(&SocketTunnel::OnConnected,

base::Unretained(this)));

if (result != net::ERR_IO_PENDING)