blimp/net/tcp_engine_transport.cc - Issue 2333923004: Extracting NetLog inner classes into their own classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/net/tcp_engine_transport.cc

Issue 2333923004: Extracting NetLog inner classes into their own classes. (Closed)

Patch Set: Some nit fixes and better, impl-agnostic naming of net_log_parameters_callback_typedef.h -> net/log… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/net/tcp_engine_transport.cc

diff --git a/blimp/net/tcp_engine_transport.cc b/blimp/net/tcp_engine_transport.cc

index b4757a065f4ac6974badf51c98a1d924ac1063b4..01026e630264cc202a00c35659da2bbdd7763368 100644

--- a/blimp/net/tcp_engine_transport.cc

+++ b/blimp/net/tcp_engine_transport.cc

@@ -13,6 +13,7 @@

#include "base/memory/ptr_util.h"

#include "base/threading/thread_task_runner_handle.h"

#include "blimp/net/message_port.h"

+#include "net/log/net_log_source.h"

#include "net/socket/stream_socket.h"

#include "net/socket/tcp_server_socket.h"

@@ -30,7 +31,7 @@ void TCPEngineTransport::Connect(const net::CompletionCallback& callback) {

if (!server_socket_) {

server_socket_.reset(

- new net::TCPServerSocket(net_log_, net::NetLog::Source()));

+ new net::TCPServerSocket(net_log_, net::NetLogSource()));

int result = server_socket_->Listen(address_, 5);

if (result != net::OK) {

server_socket_.reset();