Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h

Issue 2333753002: Remove equalIgnoringCase in Source/platform/weborigin/ (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h
diff --git a/third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h b/third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h
index 1d2846f314bfea56741af294272a21dab77a3e34..99d994a34556ca783bdd6b496275bc845eb54d03 100644
--- a/third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h
+++ b/third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h
@@ -85,7 +85,7 @@ private:
PLATFORM_EXPORT inline bool operator==(const OriginAccessEntry& a, const OriginAccessEntry& b)
{
- return equalIgnoringCase(a.protocol(), b.protocol())
+ return equalIgnoringASCIICase(a.protocol(), b.protocol())
dsinclair 2016/09/12 14:57:55 As far as I can tell this is ASCII, is that correc
&& equalIgnoringCase(a.host(), b.host())
dsinclair 2016/09/12 14:57:55 This one I wasn't sure of, should it be ASCII or U
esprehn 2016/09/12 18:58:02 Seems like it should be ASCII. This API of using o
dsinclair 2016/09/12 19:50:07 Done.
&& a.subdomainSettings() == b.subdomainSettings();
}

Powered by Google App Engine
This is Rietveld 408576698