Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h

Issue 2333753002: Remove equalIgnoringCase in Source/platform/weborigin/ (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 String m_protocol; 78 String m_protocol;
79 String m_host; 79 String m_host;
80 String m_registerableDomain; 80 String m_registerableDomain;
81 SubdomainSetting m_subdomainSettings; 81 SubdomainSetting m_subdomainSettings;
82 bool m_hostIsIPAddress; 82 bool m_hostIsIPAddress;
83 bool m_hostIsPublicSuffix; 83 bool m_hostIsPublicSuffix;
84 }; 84 };
85 85
86 PLATFORM_EXPORT inline bool operator==(const OriginAccessEntry& a, const OriginA ccessEntry& b) 86 PLATFORM_EXPORT inline bool operator==(const OriginAccessEntry& a, const OriginA ccessEntry& b)
87 { 87 {
88 return equalIgnoringCase(a.protocol(), b.protocol()) 88 return equalIgnoringASCIICase(a.protocol(), b.protocol())
dsinclair 2016/09/12 14:57:55 As far as I can tell this is ASCII, is that correc
89 && equalIgnoringCase(a.host(), b.host()) 89 && equalIgnoringCase(a.host(), b.host())
dsinclair 2016/09/12 14:57:55 This one I wasn't sure of, should it be ASCII or U
esprehn 2016/09/12 18:58:02 Seems like it should be ASCII. This API of using o
dsinclair 2016/09/12 19:50:07 Done.
90 && a.subdomainSettings() == b.subdomainSettings(); 90 && a.subdomainSettings() == b.subdomainSettings();
91 } 91 }
92 92
93 PLATFORM_EXPORT inline bool operator!=(const OriginAccessEntry& a, const OriginA ccessEntry& b) 93 PLATFORM_EXPORT inline bool operator!=(const OriginAccessEntry& a, const OriginA ccessEntry& b)
94 { 94 {
95 return !(a == b); 95 return !(a == b);
96 } 96 }
97 97
98 } // namespace blink 98 } // namespace blink
99 99
100 #endif // OriginAccessEntry_h 100 #endif // OriginAccessEntry_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698