Remove equalIgnoringCase in Source/platform/weborigin/

Remove equalIgnoringCase in Source/platform/weborigin/

This Cl updates the calls to equalIgnoringCase to use equalIgnoringASCIICase
as needed.

BUG=627682
Committed: https://crrev.com/9c8ff23720e4f5a6d27283e8f67bc97e7d18b6ed
Cr-Commit-Position: refs/heads/master@{#418341}

[dsinclair, 2016-09-12 14:57:55]

dsinclair@chromium.org changed reviewers:
+ esprehn@chromium.org

[dsinclair, 2016-09-12 14:57:55]

PTAL.

https://codereview.chromium.org/2333753002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h (right):

https://codereview.chromium.org/2333753002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h:88: return
equalIgnoringASCIICase(a.protocol(), b.protocol())
As far as I can tell this is ASCII, is that correct?

https://codereview.chromium.org/2333753002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h:89: &&
equalIgnoringCase(a.host(), b.host())
This one I wasn't sure of, should it be ASCII or Unicode?

[esprehn, 2016-09-12 18:58:02]

lgtm

https://codereview.chromium.org/2333753002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h (right):

https://codereview.chromium.org/2333753002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h:89: &&
equalIgnoringCase(a.host(), b.host())
On 2016/09/12 at 14:57:55, dsinclair wrote:
> This one I wasn't sure of, should it be ASCII or Unicode?

Seems like it should be ASCII. This API of using operator== to make two things
equal that have different fields is strange though.

[dsinclair, 2016-09-12 19:49:59]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[dsinclair, 2016-09-12 19:50:07]

https://codereview.chromium.org/2333753002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h (right):

https://codereview.chromium.org/2333753002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/weborigin/OriginAccessEntry.h:89: &&
equalIgnoringCase(a.host(), b.host())
On 2016/09/12 18:58:02, esprehn wrote:
> On 2016/09/12 at 14:57:55, dsinclair wrote:
> > This one I wasn't sure of, should it be ASCII or Unicode?
> 
> Seems like it should be ASCII. This API of using operator== to make two things
> equal that have different fields is strange though.

Done.

[commit-bot: I haz the power, 2016-09-12 19:50:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 21:17:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 21:17:51]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-09-13 13:18:30]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-13 13:18:31]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2333753002/#ps20001
(title: "Switch to ASCII")

[commit-bot: I haz the power, 2016-09-13 13:18:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 13:26:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 13:26:06]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dsinclair, 2016-09-13 14:21:22]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-13 14:21:22]

The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org
Link to the patchset: https://codereview.chromium.org/2333753002/#ps40001
(title: "Rebase to master")

[commit-bot: I haz the power, 2016-09-13 14:21:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 18:03:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 18:03:14]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dsinclair, 2016-09-13 18:06:07]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-09-13 18:06:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 19:49:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-13 19:51:55]

Description was changed from

==========
Remove equalIgnoringCase in Source/platform/weborigin/

This Cl updates the calls to equalIgnoringCase to use equalIgnoringASCIICase
as needed.

BUG=627682
==========

to

==========
Remove equalIgnoringCase in Source/platform/weborigin/

This Cl updates the calls to equalIgnoringCase to use equalIgnoringASCIICase
as needed.

BUG=627682

Committed: https://crrev.com/9c8ff23720e4f5a6d27283e8f67bc97e7d18b6ed
Cr-Commit-Position: refs/heads/master@{#418341}
==========

[commit-bot: I haz the power, 2016-09-13 19:51:56]

Patchset 3 (id:??) landed as
https://crrev.com/9c8ff23720e4f5a6d27283e8f67bc97e7d18b6ed
Cr-Commit-Position: refs/heads/master@{#418341}