Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2333743002: Don't paint backgrounds with border radius on scrolling contents layer. (Closed)

Created:
4 years, 3 months ago by flackr
Modified:
4 years, 3 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't paint backgrounds with border radius on scrolling contents layer. BUG=645941, 645949 TEST=PaintLayerScrollableAreaTest.ShouldPaintBackgroundOntoScrollingContentsLayer CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/a5e4a2686447be53c5fa482e10190ab568364efe Cr-Commit-Position: refs/heads/master@{#418006}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
flackr
Hey, Can you take a look? I think we should be able to handle border-radius ...
4 years, 3 months ago (2016-09-12 14:16:18 UTC) #3
chrishtr
lgtm
4 years, 3 months ago (2016-09-12 18:01:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333743002/1
4 years, 3 months ago (2016-09-12 18:03:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 19:38:55 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 19:40:45 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5e4a2686447be53c5fa482e10190ab568364efe
Cr-Commit-Position: refs/heads/master@{#418006}

Powered by Google App Engine
This is Rietveld 408576698