Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 2333743002: Don't paint backgrounds with border radius on scrolling contents layer. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
7 * Copyright (C) 2010 Google Inc. All rights reserved. 7 * Copyright (C) 2010 Google Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 bool hasCustomScrollbars = false; 125 bool hasCustomScrollbars = false;
126 // TODO(flackr): Detect opaque custom scrollbars which would cover up a bord er-box 126 // TODO(flackr): Detect opaque custom scrollbars which would cover up a bord er-box
127 // background. 127 // background.
128 if (PaintLayerScrollableArea* scrollableArea = getScrollableArea()) { 128 if (PaintLayerScrollableArea* scrollableArea = getScrollableArea()) {
129 if ((scrollableArea->horizontalScrollbar() && scrollableArea->horizontal Scrollbar()->isCustomScrollbar()) 129 if ((scrollableArea->horizontalScrollbar() && scrollableArea->horizontal Scrollbar()->isCustomScrollbar())
130 || (scrollableArea->verticalScrollbar() && scrollableArea->verticalS crollbar()->isCustomScrollbar())) { 130 || (scrollableArea->verticalScrollbar() && scrollableArea->verticalS crollbar()->isCustomScrollbar())) {
131 hasCustomScrollbars = true; 131 hasCustomScrollbars = true;
132 } 132 }
133 } 133 }
134 134
135 // TODO(flackr): We should be able to paint locally attached borders with a border-radius
136 // but these currently do not paint correctly. https://crbug.com/645949
137 if (style()->hasBorderRadius())
138 return false;
139
135 const FillLayer* layer = &(style()->backgroundLayers()); 140 const FillLayer* layer = &(style()->backgroundLayers());
136 for (; layer; layer = layer->next()) { 141 for (; layer; layer = layer->next()) {
137 if (layer->attachment() == LocalBackgroundAttachment) 142 if (layer->attachment() == LocalBackgroundAttachment)
138 continue; 143 continue;
139 144
140 // If the outline draws inside the border, it intends to draw on top of the scroller's background, 145 // If the outline draws inside the border, it intends to draw on top of the scroller's background,
141 // however because it is painted into a layer behind the scrolling conte nts layer we avoid auto 146 // however because it is painted into a layer behind the scrolling conte nts layer we avoid auto
142 // promoting in this case to avoid obscuring the outline. 147 // promoting in this case to avoid obscuring the outline.
143 // TODO(flackr): Outlines should be drawn on top of the scrolling conten ts layer so that 148 // TODO(flackr): Outlines should be drawn on top of the scrolling conten ts layer so that
144 // they cannot be covered up by composited scrolling contents. 149 // they cannot be covered up by composited scrolling contents.
(...skipping 1025 matching lines...) Expand 10 before | Expand all | Expand 10 after
1170 if (rootElementStyle->hasBackground()) 1175 if (rootElementStyle->hasBackground())
1171 return false; 1176 return false;
1172 1177
1173 if (node() != document().firstBodyElement()) 1178 if (node() != document().firstBodyElement())
1174 return false; 1179 return false;
1175 1180
1176 return true; 1181 return true;
1177 } 1182 }
1178 1183
1179 } // namespace blink 1184 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698