Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2333653002: scheduler: Don't throttle 0x0 frames (Closed)

Created:
4 years, 3 months ago by Sami
Modified:
4 years, 3 months ago
Reviewers:
ojan
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

scheduler: Don't throttle 0x0 frames This patch avoids throttling requestAnimationFrame and timers inside 0x0 frames. The reason is that some websites (e.g., GMail) use cross origin 0x0 frames to drive UI logic and throttling these frames causes breakage. This change also makes us match Safari's behavior. This patch also removes the test for throttling out-of-process iframes, because it turns out the viewport intersection code is not able to compute intersections across process boundaries. This capability will be restored when IntersectionObserver gains support for out-of-process iframes. BUG=644217 Committed: https://crrev.com/b83d755a52a7fe9792af9ee360e551c157ad576e Cr-Commit-Position: refs/heads/master@{#418174}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -66 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp View 3 chunks +28 lines, -64 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Sami
4 years, 3 months ago (2016-09-12 10:15:37 UTC) #5
ojan
lgtm
4 years, 3 months ago (2016-09-13 05:12:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333653002/1
4 years, 3 months ago (2016-09-13 05:12:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 05:16:41 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 05:18:55 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b83d755a52a7fe9792af9ee360e551c157ad576e
Cr-Commit-Position: refs/heads/master@{#418174}

Powered by Google App Engine
This is Rietveld 408576698