scheduler: Don't throttle 0x0 frames

third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "bindings/core/v8/ScriptController.h"
 #include "core/dom/Document.h"
 #include "core/dom/Element.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/LocalFrame.h"
 #include "core/html/HTMLIFrameElement.h"
@@ skipping 87 matching lines @@
     EXPECT_FALSE(document().view()->isHiddenForThrottling());
     EXPECT_TRUE(frameDocument->view()->isHiddenForThrottling());
 
     // A partially visible child is considered visible.
     frameElement->setAttribute(styleAttr, "transform: translate(-50px, 0px, 0px)");
     compositeFrame();
     EXPECT_FALSE(document().view()->isHiddenForThrottling());
     EXPECT_FALSE(frameDocument->view()->isHiddenForThrottling());
 }
 
-TEST_F(FrameThrottlingTest, ViewportVisibilityFullyClipped)
-{
-    SimRequest mainResource("https://example.com/", "text/html");
-
-    loadURL("https://example.com/");
-    mainResource.complete("<iframe sandbox id=frame></iframe>");
-
-    // A child which is fully clipped away by its ancestor should become invisible.
-    webView().resize(WebSize(0, 0));
-    compositeFrame();
-
-    EXPECT_TRUE(document().view()->isHiddenForThrottling());
-
-    auto* frameElement = toHTMLIFrameElement(document().getElementById("frame"));
-    auto* frameDocument = frameElement->contentDocument();
-    EXPECT_TRUE(frameDocument->view()->isHiddenForThrottling());
-}
-
 TEST_F(FrameThrottlingTest, HiddenSameOriginFramesAreNotThrottled)
 {
     SimRequest mainResource("https://example.com/", "text/html");
     SimRequest frameResource("https://example.com/iframe.html", "text/html");
 
     loadURL("https://example.com/");
     mainResource.complete("<iframe id=frame src=iframe.html></iframe>");
     frameResource.complete("<iframe id=innerFrame></iframe>");
 
     auto* frameElement = toHTMLIFrameElement(document().getElementById("frame"));
@@ skipping 35 matching lines @@
     EXPECT_FALSE(innerFrameDocument->view()->canThrottleRendering());
 
     // Hidden cross origin frames are throttled.
     frameElement->setAttribute(styleAttr, "transform: translateY(480px)");
     compositeFrame();
     EXPECT_FALSE(document().view()->canThrottleRendering());
     EXPECT_FALSE(frameDocument->view()->canThrottleRendering());
     EXPECT_TRUE(innerFrameDocument->view()->canThrottleRendering());
 }
 
+TEST_F(FrameThrottlingTest, HiddenCrossOriginZeroByZeroFramesAreNotThrottled)
+{
+    // Create a document with doubly nested iframes.
+    SimRequest mainResource("https://example.com/", "text/html");
+    SimRequest frameResource("https://example.com/iframe.html", "text/html");
+
+    loadURL("https://example.com/");
+    mainResource.complete("<iframe id=frame src=iframe.html></iframe>");
+    frameResource.complete("<iframe id=innerFrame width=0 height=0 sandbox></iframe>");
+
+    auto* frameElement = toHTMLIFrameElement(document().getElementById("frame"));
+    auto* frameDocument = frameElement->contentDocument();
+
+    auto* innerFrameElement = toHTMLIFrameElement(frameDocument->getElementById("innerFrame"));
+    auto* innerFrameDocument = innerFrameElement->contentDocument();
+
+    EXPECT_FALSE(document().view()->canThrottleRendering());
+    EXPECT_FALSE(frameDocument->view()->canThrottleRendering());
+    EXPECT_FALSE(innerFrameDocument->view()->canThrottleRendering());
+
+    // The frame is not throttled because its dimensions are 0x0.
+    frameElement->setAttribute(styleAttr, "transform: translateY(480px)");
+    compositeFrame();
+    EXPECT_FALSE(document().view()->canThrottleRendering());
+    EXPECT_FALSE(frameDocument->view()->canThrottleRendering());
+    EXPECT_FALSE(innerFrameDocument->view()->canThrottleRendering());
+}
+
 TEST_F(FrameThrottlingTest, ThrottledLifecycleUpdate)
 {
     SimRequest mainResource("https://example.com/", "text/html");
 
     loadURL("https://example.com/");
     mainResource.complete("<iframe sandbox id=frame></iframe>");
 
     auto* frameElement = toHTMLIFrameElement(document().getElementById("frame"));
     auto* frameDocument = frameElement->contentDocument();
 
@@ skipping 226 matching lines @@
 
     // Give the frame focus and do another composite. The selection in the
     // compositor should be cleared because the frame is throttled.
     EXPECT_FALSE(compositor().hasSelection());
     document().page()->focusController().setFocusedFrame(frameElement->contentDocument()->frame());
     document().body()->setAttribute(styleAttr, "background: green");
     compositeFrame();
     EXPECT_FALSE(compositor().hasSelection());
 }
 
-TEST(RemoteFrameThrottlingTest, ThrottledLocalRoot)
-{
-    FrameTestHelpers::TestWebViewClient viewClient;
-    WebViewImpl* webView = WebViewImpl::create(&viewClient, WebPageVisibilityStateVisible);
-    webView->resize(WebSize(640, 480));
-
-    // Create a remote root frame with a local child frame.
-    FrameTestHelpers::TestWebRemoteFrameClient remoteClient;
-    webView->setMainFrame(remoteClient.frame());
-    remoteClient.frame()->setReplicatedOrigin(WebSecurityOrigin::createUnique());
-
-    WebFrameOwnerProperties properties;
-    WebRemoteFrame* rootFrame = webView->mainFrame()->toWebRemoteFrame();
-    WebLocalFrame* localFrame = FrameTestHelpers::createLocalChild(rootFrame);
-
-    WebString baseURL("http://internal.test/");
-    URLTestHelpers::registerMockedURLFromBaseURL(baseURL, "simple_div.html");
-    FrameTestHelpers::loadFrame(localFrame, baseURL.utf8() + "simple_div.html");
-
-    FrameView* frameView = toWebLocalFrameImpl(localFrame)->frameView();
-    EXPECT_TRUE(frameView->frame().isLocalRoot());
-
-    // Enable throttling for the child frame.
-    frameView->setFrameRect(IntRect(0, 480, frameView->width(), frameView->height()));
-    frameView->frame().securityContext()->setSecurityOrigin(SecurityOrigin::createUnique());
-    frameView->updateAllLifecyclePhases();
-    testing::runPendingTasks();
-    EXPECT_TRUE(frameView->canThrottleRendering());
-
-    Document* frameDocument = frameView->frame().document();
-    EXPECT_EQ(DocumentLifecycle::PaintClean, frameDocument->lifecycle().state());
-
-    // Mutate the local child frame contents.
-    auto* divElement = frameDocument->getElementById("div");
-    divElement->setAttribute(styleAttr, "width: 50px");
-    EXPECT_EQ(DocumentLifecycle::VisualUpdatePending, frameDocument->lifecycle().state());
-
-    // Update the lifecycle again. The frame's lifecycle should not advance
-    // because of throttling even though it is the local root.
-    DocumentLifecycle::AllowThrottlingScope throttlingScope(frameDocument->lifecycle());
-    frameView->updateAllLifecyclePhases();
-    testing::runPendingTasks();
-    EXPECT_EQ(DocumentLifecycle::VisualUpdatePending, frameDocument->lifecycle().state());
-    webView->close();
-}
-
 TEST_F(FrameThrottlingTest, ScrollingCoordinatorShouldSkipThrottledFrame)
 {
     webView().settings()->setAcceleratedCompositingEnabled(true);
 
     // Create a hidden frame which is throttled.
     SimRequest mainResource("https://example.com/", "text/html");
     SimRequest frameResource("https://example.com/iframe.html", "text/html");
 
     loadURL("https://example.com/");
     mainResource.complete("<iframe id=frame sandbox src=iframe.html></iframe>");
@@ skipping 363 matching lines @@
     localFrame->script().executeScriptInMainWorld(
         "window.requestAnimationFrame(function() {\n"
         "  var throttledFrame = window.parent.frames.first;\n"
         "  throttledFrame.document.documentElement.style = 'margin: 50px';\n"
         "  throttledFrame.document.querySelector('#d').getBoundingClientRect();\n"
         "});\n");
     compositeFrame();
 }
 
 } // namespace blink