Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: chrome/browser/prerender/prerender_contents.h

Issue 233353003: Only commit cookie changes in prerenders after a prerender is shown (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Add browser tests, fix a bug in what was changed yesterday. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_contents.h
===================================================================
--- chrome/browser/prerender/prerender_contents.h (revision 265252)
+++ chrome/browser/prerender/prerender_contents.h (working copy)
@@ -39,6 +39,10 @@
struct HistoryAddPageArgs;
}
+namespace net {
+class URLRequestContextGetter;
+}
+
namespace prerender {
class PrerenderHandle;
@@ -46,7 +50,8 @@
class PrerenderResourceThrottle;
class PrerenderContents : public content::NotificationObserver,
- public content::WebContentsObserver {
+ public content::WebContentsObserver,
+ public base::SupportsWeakPtr<PrerenderContents> {
public:
// PrerenderContents::Create uses the currently registered Factory to create
// the PrerenderContents. Factory is intended for testing.
@@ -151,7 +156,8 @@
virtual void StartPrerendering(
int creator_child_id,
const gfx::Size& size,
- content::SessionStorageNamespace* session_storage_namespace);
+ content::SessionStorageNamespace* session_storage_namespace,
+ net::URLRequestContextGetter* request_context);
// Verifies that the prerendering is not using too many resources, and kills
// it if not.

Powered by Google App Engine
This is Rietveld 408576698