Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 2333403002: Switch default for SkGaussianBlurShader radius size. (Closed)

Created:
4 years, 3 months ago by jvanverth1
Modified:
4 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Switch default for SkGaussianBlurShader radius size. One step towards removing the 6.2 radius entirely. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333403002 TBR=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/c20c0c09254a4f77dfa9094a4e820a85e0c8121d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M gm/reveal.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M include/effects/SkGaussianEdgeShader.h View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleAndroidShadows.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
jvanverth1
4 years, 3 months ago (2016-09-13 19:16:05 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/2333403002/diff/1/gm/reveal.cpp File gm/reveal.cpp (right): https://codereview.chromium.org/2333403002/diff/1/gm/reveal.cpp#newcode350 gm/reveal.cpp:350: // G channel is an F6.2 radius Can ...
4 years, 3 months ago (2016-09-13 19:21:48 UTC) #4
jvanverth1
https://codereview.chromium.org/2333403002/diff/1/gm/reveal.cpp File gm/reveal.cpp (right): https://codereview.chromium.org/2333403002/diff/1/gm/reveal.cpp#newcode350 gm/reveal.cpp:350: // G channel is an F6.2 radius On 2016/09/13 ...
4 years, 3 months ago (2016-09-13 19:43:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333403002/20001
4 years, 3 months ago (2016-09-13 20:41:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/13772)
4 years, 3 months ago (2016-09-13 20:44:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2333403002/20001
4 years, 3 months ago (2016-09-14 14:03:35 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 14:04:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c20c0c09254a4f77dfa9094a4e820a85e0c8121d

Powered by Google App Engine
This is Rietveld 408576698