[Offline Pages] Fixes PrerenderingLoader bug to clear session_contents_ when PrerenderManager does …

[Offline Pages] Fixes PrerenderingLoader bug to clear session_contents_ when PrerenderManager does not start prerendering after all.

BUG=646127
Committed: https://crrev.com/5eeb4999bf5ea6f9d12d4c96e4285f97762085ae
Cr-Commit-Position: refs/heads/master@{#418321}

[dougarnett, 2016-09-13 15:08:33]

The CQ bit was checked by dougarnett@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 15:08:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougarnett, 2016-09-13 15:10:46]

The CQ bit was checked by dougarnett@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 15:10:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dougarnett, 2016-09-13 15:12:05]

dougarnett@chromium.org changed reviewers:
+ dewittj@chromium.org

[dougarnett, 2016-09-13 15:12:06]

I think this simple fix is good. Also looks like debug build issue only.

[commit-bot: I haz the power, 2016-09-13 15:48:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 15:48:31]

Dry run: This issue passed the CQ dry run.

[dewittj, 2016-09-13 17:03:17]

lgtm

https://codereview.chromium.org/2333333002/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/prerendering_loader.cc (right):

https://codereview.chromium.org/2333333002/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/prerendering_loader.cc:45:
session_contents_.reset(content::WebContents::Create(
nit: I have a slight preference for putting it into a local unique_ptr instead,
and update session_contents_ after we know it'll be used.

https://codereview.chromium.org/2333333002/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/prerendering_loader.cc:53:
session_contents_.reset(nullptr);
It is unfortunate that we have to create a web contents only to destroy it
immediately afterwards.  I suppose there's no way to do this without it?

[dougarnett, 2016-09-13 18:15:23]

https://codereview.chromium.org/2333333002/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/prerendering_loader.cc (right):

https://codereview.chromium.org/2333333002/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/prerendering_loader.cc:45:
session_contents_.reset(content::WebContents::Create(
On 2016/09/13 17:03:17, dewittj wrote:
> nit: I have a slight preference for putting it into a local unique_ptr
instead,
> and update session_contents_ after we know it'll be used.

Done. Please check.

https://codereview.chromium.org/2333333002/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/prerendering_loader.cc:53:
session_contents_.reset(nullptr);
On 2016/09/13 17:03:17, dewittj wrote:
> It is unfortunate that we have to create a web contents only to destroy it
> immediately afterwards.  I suppose there's no way to do this without it?

Acknowledged.

[dougarnett, 2016-09-13 18:15:30]

The CQ bit was checked by dougarnett@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 18:16:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dewittj, 2016-09-13 18:22:21]

still lgtm, thanks!

[dougarnett, 2016-09-13 18:25:41]

The CQ bit was unchecked by dougarnett@chromium.org

[dougarnett, 2016-09-13 18:25:46]

The CQ bit was checked by dougarnett@chromium.org

[commit-bot: I haz the power, 2016-09-13 18:26:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 18:59:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-13 19:01:58]

Description was changed from

==========
[Offline Pages] Fixes PrerenderingLoader bug to clear session_contents_ when
PrerenderManager does not start prerendering after all.

BUG=646127
==========

to

==========
[Offline Pages] Fixes PrerenderingLoader bug to clear session_contents_ when
PrerenderManager does not start prerendering after all.

BUG=646127

Committed: https://crrev.com/5eeb4999bf5ea6f9d12d4c96e4285f97762085ae
Cr-Commit-Position: refs/heads/master@{#418321}
==========

[commit-bot: I haz the power, 2016-09-13 19:01:59]

Patchset 3 (id:??) landed as
https://crrev.com/5eeb4999bf5ea6f9d12d4c96e4285f97762085ae
Cr-Commit-Position: refs/heads/master@{#418321}