Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5545)

Unified Diff: chrome/browser/android/offline_pages/prerendering_loader.cc

Issue 2333333002: [Offline Pages] Fixes PrerenderingLoader bug to clear session_contents_ when PrerenderManager does … (Closed)
Patch Set: Update per dewittj feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/prerendering_loader_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/prerendering_loader.cc
diff --git a/chrome/browser/android/offline_pages/prerendering_loader.cc b/chrome/browser/android/offline_pages/prerendering_loader.cc
index 2584933c487dc4fe7788b1e07ae5e5eec829e0e0..bbc1fe0851ac8f1d9753ce70fbdbde02b3ff795a 100644
--- a/chrome/browser/android/offline_pages/prerendering_loader.cc
+++ b/chrome/browser/android/offline_pages/prerendering_loader.cc
@@ -42,11 +42,12 @@ bool PrerenderingLoader::LoadPage(const GURL& url,
// Create a WebContents instance to define and hold a SessionStorageNamespace
// for this load request.
DCHECK(!session_contents_.get());
- session_contents_.reset(content::WebContents::Create(
- content::WebContents::CreateParams(browser_context_)));
+ std::unique_ptr<content::WebContents> new_web_contents(
+ content::WebContents::Create(
+ content::WebContents::CreateParams(browser_context_)));
content::SessionStorageNamespace* sessionStorageNamespace =
- session_contents_->GetController().GetDefaultSessionStorageNamespace();
- gfx::Size renderWindowSize = session_contents_->GetContainerBounds().size();
+ new_web_contents->GetController().GetDefaultSessionStorageNamespace();
+ gfx::Size renderWindowSize = new_web_contents->GetContainerBounds().size();
bool accepted = adapter_->StartPrerender(
browser_context_, url, sessionStorageNamespace, renderWindowSize);
if (!accepted)
@@ -56,6 +57,7 @@ bool PrerenderingLoader::LoadPage(const GURL& url,
snapshot_controller_.reset(
new SnapshotController(base::ThreadTaskRunnerHandle::Get(), this));
callback_ = callback;
+ session_contents_.swap(new_web_contents);
state_ = State::PENDING;
return true;
}
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/prerendering_loader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698