tests/gclient_utils_test.py - Issue 233333003: Make it possible to refer to github-style URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/gclient_utils_test.py

Issue 233333003: Make it possible to refer to github-style URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Fixing splitting and added unit test to prove it. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/gclient_utils_test.py

diff --git a/tests/gclient_utils_test.py b/tests/gclient_utils_test.py

index e8e667918ab65aa67867b9088dc1add99802bab2..39a3d772d816a0d3eeda577ba6f70a42cbed2866 100755

--- a/tests/gclient_utils_test.py

+++ b/tests/gclient_utils_test.py

@@ -124,6 +124,13 @@ class SplitUrlRevisionTestCase(GclientUtilBase):

out_url, out_rev = gclient_utils.SplitUrlRevision("%s@%s" % (url, rev))

self.assertEquals(out_rev, rev)

self.assertEquals(out_url, url)

+ url = "git@github.com:dart-lang/spark.git"

bradn 2014/04/11 04:48:48 Oh yeah, tests :-)

Sheridan Rawlins 2014/04/11 15:49:18 Added one more for the gclient.py change.

+ out_url, out_rev = gclient_utils.SplitUrlRevision(url)

+ self.assertEquals(out_rev, None)

+ self.assertEquals(out_url, url)

+ out_url, out_rev = gclient_utils.SplitUrlRevision("%s@%s" % (url, rev))

+ self.assertEquals(out_rev, rev)

+ self.assertEquals(out_url, url)

def testSVNUrl(self):

url = "svn://example.com/test"

« gclient_utils.py ('K') | « gclient_utils.py ('k') | no next file » | no next file with comments »