gclient_utils.py - Issue 233333003: Make it possible to refer to github-style URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gclient_utils.py

Issue 233333003: Make it possible to refer to github-style URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Fixing splitting and added unit test to prove it. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gclient_utils.py

diff --git a/gclient_utils.py b/gclient_utils.py

index c394862f76645aaef15b9352f68a3585be422998..d082fb7e706c7e808e7de9d0a519a8c5df9a58d7 100644

--- a/gclient_utils.py

+++ b/gclient_utils.py

@@ -75,7 +75,10 @@ def SplitUrlRevision(url):

regex = r'(ssh://(?:[-.\w]+@)?[-\w:\.]+/[-~\w\./]+)(?:@(.+))?'

components = re.search(regex, url).groups()

else:

- components = url.split('@', 1)

+ components = url.rsplit('@', 1)

+ if re.match(r'^\w+\@', url) and '@' not in components[0]:

+ components = [url]

bradn 2014/04/11 04:48:48 ah, even better!

if len(components) == 1:

components += [None]

return tuple(components)

« no previous file with comments | « gclient.py ('k') | tests/gclient_utils_test.py » ('j') | tests/gclient_utils_test.py » ('J')