Update gn_android_flavor for Vulkan.

Update gn_android_flavor for Vulkan.

C.f. https://codereview.chromium.org/2336343002 for basic GN support.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333293004

Committed: https://skia.googlesource.com/skia/+/357f9d2032d65a3be28cd93af9d99c0de19a2d0f

[mtklein_C, 2016-09-13 19:06:53]

Description was changed from

==========
Update gn_android_flavor for Vulkan.

C.f. https://codereview.chromium.org/2336343002 for basic GN support.

BUG=skia:
==========

to

==========
Update gn_android_flavor for Vulkan.

C.f. https://codereview.chromium.org/2336343002 for basic GN support.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333293004
==========

[mtklein_C, 2016-09-13 19:07:54]

mtklein@chromium.org changed reviewers:
+ borenet@google.com, jcgregorio@google.com

[borenet, 2016-09-13 19:15:47]

LGTM with question.

https://codereview.chromium.org/2333293004/diff/1/infra/bots/recipe_modules/f...
File infra/bots/recipe_modules/flavor/gn_android_flavor.py (right):

https://codereview.chromium.org/2333293004/diff/1/infra/bots/recipe_modules/f...
infra/bots/recipe_modules/flavor/gn_android_flavor.py:59: args['is_debug'] =
'false'
I take it is_debug is true by default?  Personally I prefer not to rely on the
default and set things like this explicitly.

[mtklein, 2016-09-13 19:22:33]

On 2016/09/13 19:15:47, borenet wrote:
> LGTM with question.
> 
>
https://codereview.chromium.org/2333293004/diff/1/infra/bots/recipe_modules/f...
> File infra/bots/recipe_modules/flavor/gn_android_flavor.py (right):
> 
>
https://codereview.chromium.org/2333293004/diff/1/infra/bots/recipe_modules/f...
> infra/bots/recipe_modules/flavor/gn_android_flavor.py:59: args['is_debug'] =
> 'false'
> I take it is_debug is true by default?  Personally I prefer not to rely on the
> default and set things like this explicitly.

Yeah.  Just keeping this in sync with gn_flavor.py, which does the same.  Since
we started to get very conditional things like ndk and ndk_api, not setting
defaults helps make the non-defaults stand out better.

[mtklein_C, 2016-09-13 20:19:47]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2016-09-13 20:19:48]

The patchset sent to the CQ was uploaded after l-g-t-m from borenet@google.com
Link to the patchset: https://codereview.chromium.org/2333293004/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-13 20:19:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 20:50:12]

Description was changed from

==========
Update gn_android_flavor for Vulkan.

C.f. https://codereview.chromium.org/2336343002 for basic GN support.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333293004
==========

to

==========
Update gn_android_flavor for Vulkan.

C.f. https://codereview.chromium.org/2336343002 for basic GN support.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333293004

Committed:
https://skia.googlesource.com/skia/+/357f9d2032d65a3be28cd93af9d99c0de19a2d0f
==========

[commit-bot: I haz the power, 2016-09-13 20:50:13]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/357f9d2032d65a3be28cd93af9d99c0de19a2d0f