GN: Android Vulkan support

GN: Android Vulkan support

Android's the easiest place to start supporting Vulkan, so it's up first.

ndk_api becomes user-specifiable so that the Vulkan bots can kick it up
to 24, the first release supporting Vulkan.  The defaults remain the same:
18 for 32-bit and 21 for 64-bit, the first release supporting 64-bit.

To test this, I set ndk_api=24 and skia_use_vulkan=true in GN, then
   $ ninja -C out dm; and droid out/dm --config vk --src gm

Seems to work!  Bot scripts to follow.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336343002

Committed: https://skia.googlesource.com/skia/+/6ef6999017febaf0039b83c1ff4da1efe9c0e85d

[mtklein_C, 2016-09-13 17:57:23]

Description was changed from

==========
GN: Android Vulkan support

Android's the easiest place to start supporting Vulkan, so it's up first.

ndk_api becomes user-specifiable so that the Vulkan bots can kick it up
to 24, the first release supporting Vulkan.  The defaults remain the same:
18 for 32-bit and 21 for 64-bit, the first release supporting 64-bit.

BUG=skia:
==========

to

==========
GN: Android Vulkan support

Android's the easiest place to start supporting Vulkan, so it's up first.

ndk_api becomes user-specifiable so that the Vulkan bots can kick it up
to 24, the first release supporting Vulkan.  The defaults remain the same:
18 for 32-bit and 21 for 64-bit, the first release supporting 64-bit.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336343002
==========

[mtklein_C, 2016-09-13 18:12:44]

Description was changed from

==========
GN: Android Vulkan support

Android's the easiest place to start supporting Vulkan, so it's up first.

ndk_api becomes user-specifiable so that the Vulkan bots can kick it up
to 24, the first release supporting Vulkan.  The defaults remain the same:
18 for 32-bit and 21 for 64-bit, the first release supporting 64-bit.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336343002
==========

to

==========
GN: Android Vulkan support

Android's the easiest place to start supporting Vulkan, so it's up first.

ndk_api becomes user-specifiable so that the Vulkan bots can kick it up
to 24, the first release supporting Vulkan.  The defaults remain the same:
18 for 32-bit and 21 for 64-bit, the first release supporting 64-bit.

To test this, I set ndk_api=24 and skia_use_vulkan=true in GN, then
   $ ninja -C out dm; and droid out/dm --config vk --src gm

Seems to work!

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336343002
==========

[mtklein_C, 2016-09-13 18:14:51]

Description was changed from

==========
GN: Android Vulkan support

Android's the easiest place to start supporting Vulkan, so it's up first.

ndk_api becomes user-specifiable so that the Vulkan bots can kick it up
to 24, the first release supporting Vulkan.  The defaults remain the same:
18 for 32-bit and 21 for 64-bit, the first release supporting 64-bit.

To test this, I set ndk_api=24 and skia_use_vulkan=true in GN, then
   $ ninja -C out dm; and droid out/dm --config vk --src gm

Seems to work!

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336343002
==========

to

==========
GN: Android Vulkan support

Android's the easiest place to start supporting Vulkan, so it's up first.

ndk_api becomes user-specifiable so that the Vulkan bots can kick it up
to 24, the first release supporting Vulkan.  The defaults remain the same:
18 for 32-bit and 21 for 64-bit, the first release supporting 64-bit.

To test this, I set ndk_api=24 and skia_use_vulkan=true in GN, then
   $ ninja -C out dm; and droid out/dm --config vk --src gm

Seems to work!  Bot scripts to follow.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336343002
==========

[mtklein_C, 2016-09-13 18:15:01]

mtklein@chromium.org changed reviewers:
+ egdaniel@google.com, jcgregorio@google.com

[mtklein_C, 2016-09-13 18:28:31]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 18:28:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jcgregorio, 2016-09-13 18:33:31]

On 2016/09/13 at 18:15:02, mtklein wrote:
> 

Won't this break if I set skia_use_vulkan=true but don't set ndk_api=24?

[mtklein, 2016-09-13 18:35:58]

On 2016/09/13 18:33:31, jcgregorio wrote:
> On 2016/09/13 at 18:15:02, mtklein wrote:
> > 
> 
> Won't this break if I set skia_use_vulkan=true but don't set ndk_api=24?

Not really break, per se, but yes that will fail to compile with a message like:

../include/gpu/vk/GrVkDefines.h:24:10: fatal error: 'vulkan/vulkan.h' file not
found
#include <vulkan/vulkan.h>

[commit-bot: I haz the power, 2016-09-13 20:13:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 20:13:51]

Dry run: This issue passed the CQ dry run.

[mtklein, 2016-09-14 13:11:02]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-09-14 13:11:03]

Gonna land this so my new bots don't get too confusing (without it they'll
appear to succeed, but be non-Vulkan bots).

[mtklein, 2016-09-14 13:11:07]

The CQ bit was checked by mtklein@google.com

[mtklein, 2016-09-14 13:11:08]

lgtm

[commit-bot: I haz the power, 2016-09-14 13:11:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 13:12:12]

Description was changed from

==========
GN: Android Vulkan support

Android's the easiest place to start supporting Vulkan, so it's up first.

ndk_api becomes user-specifiable so that the Vulkan bots can kick it up
to 24, the first release supporting Vulkan.  The defaults remain the same:
18 for 32-bit and 21 for 64-bit, the first release supporting 64-bit.

To test this, I set ndk_api=24 and skia_use_vulkan=true in GN, then
   $ ninja -C out dm; and droid out/dm --config vk --src gm

Seems to work!  Bot scripts to follow.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336343002
==========

to

==========
GN: Android Vulkan support

Android's the easiest place to start supporting Vulkan, so it's up first.

ndk_api becomes user-specifiable so that the Vulkan bots can kick it up
to 24, the first release supporting Vulkan.  The defaults remain the same:
18 for 32-bit and 21 for 64-bit, the first release supporting 64-bit.

To test this, I set ndk_api=24 and skia_use_vulkan=true in GN, then
   $ ninja -C out dm; and droid out/dm --config vk --src gm

Seems to work!  Bot scripts to follow.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336343002

Committed:
https://skia.googlesource.com/skia/+/6ef6999017febaf0039b83c1ff4da1efe9c0e85d
==========

[commit-bot: I haz the power, 2016-09-14 13:12:12]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6ef6999017febaf0039b83c1ff4da1efe9c0e85d