Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 2336343002: GN: Android Vulkan support (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: Android Vulkan support Android's the easiest place to start supporting Vulkan, so it's up first. ndk_api becomes user-specifiable so that the Vulkan bots can kick it up to 24, the first release supporting Vulkan. The defaults remain the same: 18 for 32-bit and 21 for 64-bit, the first release supporting 64-bit. To test this, I set ndk_api=24 and skia_use_vulkan=true in GN, then $ ninja -C out dm; and droid out/dm --config vk --src gm Seems to work! Bot scripts to follow. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336343002 Committed: https://skia.googlesource.com/skia/+/6ef6999017febaf0039b83c1ff4da1efe9c0e85d

Patch Set 1 #

Patch Set 2 : Seems to work. #

Patch Set 3 : comment #

Patch Set 4 : simpler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -7 lines) Patch
M BUILD.gn View 1 5 chunks +14 lines, -0 lines 0 comments Download
M gn/BUILDCONFIG.gn View 1 2 3 3 chunks +16 lines, -7 lines 0 comments Download
M gn/shared_sources.gni View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
mtklein_C
4 years, 3 months ago (2016-09-13 18:15:02 UTC) #5
jcgregorio
On 2016/09/13 at 18:15:02, mtklein wrote: > Won't this break if I set skia_use_vulkan=true but ...
4 years, 3 months ago (2016-09-13 18:33:31 UTC) #8
mtklein
On 2016/09/13 18:33:31, jcgregorio wrote: > On 2016/09/13 at 18:15:02, mtklein wrote: > > > ...
4 years, 3 months ago (2016-09-13 18:35:58 UTC) #9
mtklein
Gonna land this so my new bots don't get too confusing (without it they'll appear ...
4 years, 3 months ago (2016-09-14 13:11:03 UTC) #13
mtklein
lgtm
4 years, 3 months ago (2016-09-14 13:11:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2336343002/60001
4 years, 3 months ago (2016-09-14 13:11:15 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 13:12:12 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/6ef6999017febaf0039b83c1ff4da1efe9c0e85d

Powered by Google App Engine
This is Rietveld 408576698