Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6127)

Unified Diff: chrome/browser/metrics/chrome_metrics_services_manager_client.h

Issue 2333283005: Move EntropyProvider Source From MetricsService to MetricsServicesManager (Closed)
Patch Set: CR Feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_metrics_services_manager_client.h
diff --git a/chrome/browser/metrics/chrome_metrics_services_manager_client.h b/chrome/browser/metrics/chrome_metrics_services_manager_client.h
index 0a4ffb17dd10fa9f9592f8d772532ee0c30ddd5e..fe3863fd60c68bd19e4b46a38433ea22e4fdf538 100644
--- a/chrome/browser/metrics/chrome_metrics_services_manager_client.h
+++ b/chrome/browser/metrics/chrome_metrics_services_manager_client.h
@@ -9,6 +9,7 @@
#include "base/feature_list.h"
#include "base/macros.h"
+#include "base/metrics/field_trial.h"
#include "base/threading/thread_checker.h"
#include "chrome/browser/safe_browsing/safe_browsing_service.h"
#include "components/metrics_services_manager/metrics_services_manager_client.h"
@@ -64,6 +65,8 @@ class ChromeMetricsServicesManagerClient
override;
std::unique_ptr<metrics::MetricsServiceClient> CreateMetricsServiceClient()
override;
+ std::unique_ptr<const base::FieldTrial::EntropyProvider>
+ CreateEntropyProvider() override;
brettw 2016/09/14 22:22:03 I think the function name should be indented 4 spa
robliao 2016/09/15 14:31:18 Referring to https://codereview.chromium.org/2333
net::URLRequestContextGetter* GetURLRequestContext() override;
bool IsSafeBrowsingEnabled(const base::Closure& on_update_callback) override;
bool IsMetricsReportingEnabled() override;

Powered by Google App Engine
This is Rietveld 408576698