Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1096)

Side by Side Diff: chrome/browser/metrics/chrome_metrics_services_manager_client.h

Issue 2333283005: Move EntropyProvider Source From MetricsService to MetricsServicesManager (Closed)
Patch Set: CR Feedback Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICES_MANAGER_CLIENT_H_ 5 #ifndef CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICES_MANAGER_CLIENT_H_
6 #define CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICES_MANAGER_CLIENT_H_ 6 #define CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICES_MANAGER_CLIENT_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/feature_list.h" 10 #include "base/feature_list.h"
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "base/metrics/field_trial.h"
12 #include "base/threading/thread_checker.h" 13 #include "base/threading/thread_checker.h"
13 #include "chrome/browser/safe_browsing/safe_browsing_service.h" 14 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
14 #include "components/metrics_services_manager/metrics_services_manager_client.h" 15 #include "components/metrics_services_manager/metrics_services_manager_client.h"
15 16
16 class PrefService; 17 class PrefService;
17 18
18 namespace metrics { 19 namespace metrics {
19 class EnabledStateProvider; 20 class EnabledStateProvider;
20 class MetricsStateManager; 21 class MetricsStateManager;
21 } 22 }
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 // ChromeMetricsServiceAccessor through ChromeMetricsServicesManagerClient's 58 // ChromeMetricsServiceAccessor through ChromeMetricsServicesManagerClient's
58 // friendship. 59 // friendship.
59 class ChromeEnabledStateProvider; 60 class ChromeEnabledStateProvider;
60 61
61 // metrics_services_manager::MetricsServicesManagerClient: 62 // metrics_services_manager::MetricsServicesManagerClient:
62 std::unique_ptr<rappor::RapporService> CreateRapporService() override; 63 std::unique_ptr<rappor::RapporService> CreateRapporService() override;
63 std::unique_ptr<variations::VariationsService> CreateVariationsService() 64 std::unique_ptr<variations::VariationsService> CreateVariationsService()
64 override; 65 override;
65 std::unique_ptr<metrics::MetricsServiceClient> CreateMetricsServiceClient() 66 std::unique_ptr<metrics::MetricsServiceClient> CreateMetricsServiceClient()
66 override; 67 override;
68 std::unique_ptr<const base::FieldTrial::EntropyProvider>
69 CreateEntropyProvider() override;
brettw 2016/09/14 22:22:03 I think the function name should be indented 4 spa
robliao 2016/09/15 14:31:18 Referring to https://codereview.chromium.org/2333
67 net::URLRequestContextGetter* GetURLRequestContext() override; 70 net::URLRequestContextGetter* GetURLRequestContext() override;
68 bool IsSafeBrowsingEnabled(const base::Closure& on_update_callback) override; 71 bool IsSafeBrowsingEnabled(const base::Closure& on_update_callback) override;
69 bool IsMetricsReportingEnabled() override; 72 bool IsMetricsReportingEnabled() override;
70 bool OnlyDoMetricsRecording() override; 73 bool OnlyDoMetricsRecording() override;
71 74
72 #if defined(OS_WIN) 75 #if defined(OS_WIN)
73 // On Windows, the client controls whether Crashpad can upload crash reports. 76 // On Windows, the client controls whether Crashpad can upload crash reports.
74 void UpdateRunningServices(bool may_record, bool may_upload) override; 77 void UpdateRunningServices(bool may_record, bool may_upload) override;
75 #endif // defined(OS_WIN) 78 #endif // defined(OS_WIN)
76 79
(...skipping 15 matching lines...) Expand all
92 PrefService* local_state_; 95 PrefService* local_state_;
93 96
94 // Subscription to SafeBrowsing service state changes. 97 // Subscription to SafeBrowsing service state changes.
95 std::unique_ptr<safe_browsing::SafeBrowsingService::StateSubscription> 98 std::unique_ptr<safe_browsing::SafeBrowsingService::StateSubscription>
96 sb_state_subscription_; 99 sb_state_subscription_;
97 100
98 DISALLOW_COPY_AND_ASSIGN(ChromeMetricsServicesManagerClient); 101 DISALLOW_COPY_AND_ASSIGN(ChromeMetricsServicesManagerClient);
99 }; 102 };
100 103
101 #endif // CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICES_MANAGER_CLIENT_H_ 104 #endif // CHROME_BROWSER_METRICS_CHROME_METRICS_SERVICES_MANAGER_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698