Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4156)

Unified Diff: chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js

Issue 2333283004: [CUPS] Implement the UI handler for adding a new printer. (Closed)
Patch Set: Address michaelpg@'s offline comment. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
diff --git a/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js b/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
index c866a6c6978960a37ca43fe02bb48e9459b9b135..3b4e4e24b326df715866d08787def2f53b723ba3 100644
--- a/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
+++ b/chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js
@@ -49,13 +49,19 @@ cr.define('settings', function() {
/**
* @param {string} printerId
+ * @param {string} printerName
*/
- removeCupsPrinter: function(printerId) {},
+ removeCupsPrinter: function(printerId, printerName) {},
/**
* @return {!Promise<string>} The full path of the printer PPD file.
*/
getCupsPrinterPPDPath: function() {},
+
+ /**
+ * @param {!CupsPrinterInfo} newPrinter
+ */
+ addCupsPrinter: function(newPrinter) {},
};
/**
@@ -77,8 +83,13 @@ cr.define('settings', function() {
},
/** @override */
- removeCupsPrinter: function(printerId) {
- chrome.send('removeCupsPrinter', [printerId]);
+ removeCupsPrinter: function(printerId, printerName) {
+ chrome.send('removeCupsPrinter', [printerId, printerName]);
+ },
+
+ /** @override */
+ addCupsPrinter: function(newPrinter) {
+ chrome.send('addCupsPrinter', [newPrinter]);
},
/** @override */

Powered by Google App Engine
This is Rietveld 408576698