chrome/browser/resources/settings/printing_page/cups_printers_list.js - Issue 2333283004: [CUPS] Implement the UI handler for adding a new printer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/printing_page/cups_printers_list.js

Issue 2333283004: [CUPS] Implement the UI handler for adding a new printer. (Closed)

Patch Set: Address michaelpg@'s offline comment. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/printing_page/cups_printers.html ('K') | « chrome/browser/resources/settings/printing_page/cups_printers_browser_proxy.js ('k') | chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/printing_page/cups_printers_list.js

diff --git a/chrome/browser/resources/settings/printing_page/cups_printers_list.js b/chrome/browser/resources/settings/printing_page/cups_printers_list.js

index d1293e3b83a460061120594bd5299d8c63053978..6364807697e375a5ddacf40486c771d430c9aecc 100644

--- a/chrome/browser/resources/settings/printing_page/cups_printers_list.js

+++ b/chrome/browser/resources/settings/printing_page/cups_printers_list.js

@@ -49,7 +49,8 @@ Polymer({

var index = this.printers.indexOf(event.model.item);

this.splice('printers', index, 1);

- this.browserProxy_.removeCupsPrinter(event.model.item.printerId);

+ this.browserProxy_.removeCupsPrinter(event.model.item.printerId,

+ event.model.item.printerName);

/** @private */