Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5028)

Unified Diff: chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.cc

Issue 2333113002: Rename DesktopEngagement* to DesktopSessionDuration*. (Closed)
Patch Set: Change name Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.cc
diff --git a/chrome/browser/metrics/desktop_engagement/desktop_engagement_observer.cc b/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.cc
similarity index 52%
rename from chrome/browser/metrics/desktop_engagement/desktop_engagement_observer.cc
rename to chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.cc
index bf4dda506a1497d4808b5de3f1fd1a80eebb4b6b..595729be732a6bf5b2e5e605eee110cc4cdd9757 100644
--- a/chrome/browser/metrics/desktop_engagement/desktop_engagement_observer.cc
+++ b/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.cc
@@ -2,59 +2,60 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/browser/metrics/desktop_engagement/desktop_engagement_observer.h"
+#include "chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.h"
-#include "chrome/browser/metrics/desktop_engagement/desktop_engagement_service.h"
+#include "chrome/browser/metrics/desktop_session_duration/desktop_session_duration_tracker.h"
#include "content/public/browser/render_view_host.h"
-DEFINE_WEB_CONTENTS_USER_DATA_KEY(metrics::DesktopEngagementObserver);
+DEFINE_WEB_CONTENTS_USER_DATA_KEY(metrics::DesktopSessionDurationObserver);
namespace metrics {
-DesktopEngagementObserver::DesktopEngagementObserver(
+DesktopSessionDurationObserver::DesktopSessionDurationObserver(
content::WebContents* web_contents,
- DesktopEngagementService* service)
+ DesktopSessionDurationTracker* service)
: content::WebContentsObserver(web_contents), service_(service) {
RegisterInputEventObserver(web_contents->GetRenderViewHost());
}
-DesktopEngagementObserver::~DesktopEngagementObserver() {}
+DesktopSessionDurationObserver::~DesktopSessionDurationObserver() {}
// static
-DesktopEngagementObserver* DesktopEngagementObserver::CreateForWebContents(
+DesktopSessionDurationObserver*
+DesktopSessionDurationObserver::CreateForWebContents(
content::WebContents* web_contents) {
DCHECK(web_contents);
- if (!DesktopEngagementService::IsInitialized())
+ if (!DesktopSessionDurationTracker::IsInitialized())
return nullptr;
- DesktopEngagementObserver* observer = FromWebContents(web_contents);
+ DesktopSessionDurationObserver* observer = FromWebContents(web_contents);
if (!observer) {
- observer = new DesktopEngagementObserver(web_contents,
- DesktopEngagementService::Get());
+ observer = new DesktopSessionDurationObserver(
+ web_contents, DesktopSessionDurationTracker::Get());
web_contents->SetUserData(UserDataKey(), observer);
}
return observer;
}
-void DesktopEngagementObserver::RegisterInputEventObserver(
+void DesktopSessionDurationObserver::RegisterInputEventObserver(
content::RenderViewHost* host) {
if (host != nullptr)
host->GetWidget()->AddInputEventObserver(this);
}
-void DesktopEngagementObserver::UnregisterInputEventObserver(
+void DesktopSessionDurationObserver::UnregisterInputEventObserver(
content::RenderViewHost* host) {
if (host != nullptr)
host->GetWidget()->RemoveInputEventObserver(this);
}
-void DesktopEngagementObserver::OnInputEvent(
+void DesktopSessionDurationObserver::OnInputEvent(
const blink::WebInputEvent& event) {
service_->OnUserEvent();
}
-void DesktopEngagementObserver::RenderViewHostChanged(
+void DesktopSessionDurationObserver::RenderViewHostChanged(
content::RenderViewHost* old_host,
content::RenderViewHost* new_host) {
UnregisterInputEventObserver(old_host);

Powered by Google App Engine
This is Rietveld 408576698