Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: chrome/browser/metrics/desktop_engagement/chrome_visibility_observer_browsertest.cc

Issue 2333113002: Rename DesktopEngagement* to DesktopSessionDuration*. (Closed)
Patch Set: Change name Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/desktop_engagement/chrome_visibility_observer_browsertest.cc
diff --git a/chrome/browser/metrics/desktop_engagement/chrome_visibility_observer_browsertest.cc b/chrome/browser/metrics/desktop_engagement/chrome_visibility_observer_browsertest.cc
deleted file mode 100644
index ea07230b242e0b38573d160fbf62edb5fcf70473..0000000000000000000000000000000000000000
--- a/chrome/browser/metrics/desktop_engagement/chrome_visibility_observer_browsertest.cc
+++ /dev/null
@@ -1,49 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.h"
-
-#include "base/memory/singleton.h"
-#include "chrome/browser/chrome_notification_types.h"
-#include "chrome/browser/ui/browser.h"
-#include "chrome/browser/ui/browser_list.h"
-#include "chrome/test/base/in_process_browser_test.h"
-#include "chrome/test/base/ui_test_utils.h"
-#include "content/public/browser/notification_service.h"
-#include "content/public/test/test_utils.h"
-
-// Mock class for |ChromeVisibilityObserver| for testing.
-class MockChromeVisibilityObserver : public metrics::ChromeVisibilityObserver {
- public:
- MockChromeVisibilityObserver() : is_active_(false) {}
-
- bool is_active() const { return is_active_; }
-
- private:
- void SendVisibilityChangeEvent(bool active) override { is_active_ = active; }
-
- bool is_active_;
-
- DISALLOW_COPY_AND_ASSIGN(MockChromeVisibilityObserver);
-};
-
-class ChromeVisibilityObserverBrowserTest : public InProcessBrowserTest {};
-
-IN_PROC_BROWSER_TEST_F(ChromeVisibilityObserverBrowserTest, VisibilityTest) {
- MockChromeVisibilityObserver observer;
-
- EXPECT_FALSE(observer.is_active());
- Browser* new_browser = CreateBrowser(browser()->profile());
- EXPECT_TRUE(observer.is_active());
-
- Browser* incognito_browser = CreateIncognitoBrowser();
- EXPECT_TRUE(observer.is_active());
-
- CloseBrowserSynchronously(incognito_browser);
- EXPECT_TRUE(observer.is_active());
-
- CloseBrowserSynchronously(new_browser);
- CloseBrowserSynchronously(browser());
- EXPECT_FALSE(observer.is_active());
-}

Powered by Google App Engine
This is Rietveld 408576698