Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.h

Issue 2333113002: Rename DesktopEngagement* to DesktopSessionDuration*. (Closed)
Patch Set: Change name Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.h
diff --git a/chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.h b/chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.h
deleted file mode 100644
index 8677b432cdfa13c55448b71246d6eff100db56cc..0000000000000000000000000000000000000000
--- a/chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.h
+++ /dev/null
@@ -1,49 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_METRICS_DESKTOP_ENGAGEMENT_CHROME_VISIBILITY_OBSERVER_H_
-#define CHROME_BROWSER_METRICS_DESKTOP_ENGAGEMENT_CHROME_VISIBILITY_OBSERVER_H_
-
-#include "base/memory/weak_ptr.h"
-#include "chrome/browser/ui/browser_list_observer.h"
-
-namespace metrics {
-
-// Observer for tracking browser visibility events.
-class ChromeVisibilityObserver : public chrome::BrowserListObserver {
- public:
- ChromeVisibilityObserver();
- ~ChromeVisibilityObserver() override;
-
- protected:
- // Notifies |DesktopEngagementService| of visibility changes. Overridden by
- // tests.
- virtual void SendVisibilityChangeEvent(bool active);
-
- private:
- // Cancels visibility change in case when the browser becomes visible after a
- // short gap.
- void CancelVisibilityChange();
-
- // chrome::BrowserListObserver:
- void OnBrowserSetLastActive(Browser* browser) override;
- void OnBrowserNoLongerActive(Browser* browser) override;
- void OnBrowserRemoved(Browser* browser) override;
-
- // Sets |visibility_gap_timeout_| based on variation params.
- void InitVisibilityGapTimeout();
-
- // Timeout interval for waiting after loss of visibility. This allows merging
- // two visibility session if they happened very shortly after each other, for
- // example, when user switching between two browser windows.
- base::TimeDelta visibility_gap_timeout_;
-
- base::WeakPtrFactory<ChromeVisibilityObserver> weak_factory_;
-
- DISALLOW_COPY_AND_ASSIGN(ChromeVisibilityObserver);
-};
-
-} // namespace metrics
-
-#endif // CHROME_BROWSER_METRICS_DESKTOP_ENGAGEMENT_CHROME_VISIBILITY_OBSERVER_H_

Powered by Google App Engine
This is Rietveld 408576698