chrome/browser/metrics/desktop_session/chrome_visibility_observer.cc - Issue 2333113002: Rename DesktopEngagement* to DesktopSessionDuration*.

Unified Diff: chrome/browser/metrics/desktop_session/chrome_visibility_observer.cc

Issue 2333113002: Rename DesktopEngagement* to DesktopSessionDuration*. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « chrome/browser/metrics/desktop_session/chrome_visibility_observer.h ('k') | chrome/browser/metrics/desktop_session/chrome_visibility_observer_browsertest.cc » ('j') | chrome/browser/metrics/desktop_session/desktop_session_service.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/desktop_session/chrome_visibility_observer.cc

diff --git a/chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.cc b/chrome/browser/metrics/desktop_session/chrome_visibility_observer.cc

similarity index 88%

rename from chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.cc

rename to chrome/browser/metrics/desktop_session/chrome_visibility_observer.cc

index fcd72072ec2c82120767b5f5fe32cb5d8c54cdd1..205b1265ecc2357e276a287c02232afcabaeaa64 100644

--- a/chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.cc

+++ b/chrome/browser/metrics/desktop_session/chrome_visibility_observer.cc

@@ -2,12 +2,12 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-#include "chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.h"

+#include "chrome/browser/metrics/desktop_session/chrome_visibility_observer.h"

#include "base/memory/singleton.h"

#include "base/strings/string_number_conversions.h"

#include "base/threading/thread_task_runner_handle.h"

-#include "chrome/browser/metrics/desktop_engagement/desktop_engagement_service.h"

+#include "chrome/browser/metrics/desktop_session/desktop_session_service.h"

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_list.h"

#include "components/variations/variations_associated_data.h"

@@ -24,7 +24,7 @@ ChromeVisibilityObserver::~ChromeVisibilityObserver() {

}

void ChromeVisibilityObserver::SendVisibilityChangeEvent(bool active) {

- DesktopEngagementService::Get()->OnVisibilityChanged(active);

+ DesktopSessionService::Get()->OnVisibilityChanged(active);

}

void ChromeVisibilityObserver::CancelVisibilityChange() {

@@ -60,7 +60,7 @@ void ChromeVisibilityObserver::InitVisibilityGapTimeout() {

int timeout_seconds = kDefaultVisibilityGapTimeout;

std::string param_value = variations::GetVariationParamValue(

- "DesktopEngagement", "visibility_gap_timeout");

+ "DesktopSession", "visibility_gap_timeout");

dominickn 2016/09/13 01:29:53 I grepped the finch studies directory and found no

gayane -on leave until 09-2017 2016/09/13 17:09:29 Thats correct the study doesn't exist at the momen

if (!param_value.empty())

base::StringToInt(param_value, &timeout_seconds);