Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: chrome/browser/metrics/desktop_session/chrome_visibility_observer.cc

Issue 2333113002: Rename DesktopEngagement* to DesktopSessionDuration*. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/metrics/desktop_engagement/chrome_visibility_observer.h " 5 #include "chrome/browser/metrics/desktop_session/chrome_visibility_observer.h"
6 6
7 #include "base/memory/singleton.h" 7 #include "base/memory/singleton.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "base/threading/thread_task_runner_handle.h" 9 #include "base/threading/thread_task_runner_handle.h"
10 #include "chrome/browser/metrics/desktop_engagement/desktop_engagement_service.h " 10 #include "chrome/browser/metrics/desktop_session/desktop_session_service.h"
11 #include "chrome/browser/ui/browser.h" 11 #include "chrome/browser/ui/browser.h"
12 #include "chrome/browser/ui/browser_list.h" 12 #include "chrome/browser/ui/browser_list.h"
13 #include "components/variations/variations_associated_data.h" 13 #include "components/variations/variations_associated_data.h"
14 14
15 namespace metrics { 15 namespace metrics {
16 16
17 ChromeVisibilityObserver::ChromeVisibilityObserver() : weak_factory_(this) { 17 ChromeVisibilityObserver::ChromeVisibilityObserver() : weak_factory_(this) {
18 BrowserList::AddObserver(this); 18 BrowserList::AddObserver(this);
19 InitVisibilityGapTimeout(); 19 InitVisibilityGapTimeout();
20 } 20 }
21 21
22 ChromeVisibilityObserver::~ChromeVisibilityObserver() { 22 ChromeVisibilityObserver::~ChromeVisibilityObserver() {
23 BrowserList::RemoveObserver(this); 23 BrowserList::RemoveObserver(this);
24 } 24 }
25 25
26 void ChromeVisibilityObserver::SendVisibilityChangeEvent(bool active) { 26 void ChromeVisibilityObserver::SendVisibilityChangeEvent(bool active) {
27 DesktopEngagementService::Get()->OnVisibilityChanged(active); 27 DesktopSessionService::Get()->OnVisibilityChanged(active);
28 } 28 }
29 29
30 void ChromeVisibilityObserver::CancelVisibilityChange() { 30 void ChromeVisibilityObserver::CancelVisibilityChange() {
31 weak_factory_.InvalidateWeakPtrs(); 31 weak_factory_.InvalidateWeakPtrs();
32 } 32 }
33 33
34 void ChromeVisibilityObserver::OnBrowserSetLastActive(Browser* browser) { 34 void ChromeVisibilityObserver::OnBrowserSetLastActive(Browser* browser) {
35 if (weak_factory_.HasWeakPtrs()) 35 if (weak_factory_.HasWeakPtrs())
36 CancelVisibilityChange(); 36 CancelVisibilityChange();
37 else 37 else
(...skipping 15 matching lines...) Expand all
53 CancelVisibilityChange(); 53 CancelVisibilityChange();
54 SendVisibilityChangeEvent(false); 54 SendVisibilityChangeEvent(false);
55 } 55 }
56 } 56 }
57 57
58 void ChromeVisibilityObserver::InitVisibilityGapTimeout() { 58 void ChromeVisibilityObserver::InitVisibilityGapTimeout() {
59 const int kDefaultVisibilityGapTimeout = 3; 59 const int kDefaultVisibilityGapTimeout = 3;
60 60
61 int timeout_seconds = kDefaultVisibilityGapTimeout; 61 int timeout_seconds = kDefaultVisibilityGapTimeout;
62 std::string param_value = variations::GetVariationParamValue( 62 std::string param_value = variations::GetVariationParamValue(
63 "DesktopEngagement", "visibility_gap_timeout"); 63 "DesktopSession", "visibility_gap_timeout");
dominickn 2016/09/13 01:29:53 I grepped the finch studies directory and found no
gayane -on leave until 09-2017 2016/09/13 17:09:29 Thats correct the study doesn't exist at the momen
64 if (!param_value.empty()) 64 if (!param_value.empty())
65 base::StringToInt(param_value, &timeout_seconds); 65 base::StringToInt(param_value, &timeout_seconds);
66 66
67 visibility_gap_timeout_ = base::TimeDelta::FromSeconds(timeout_seconds); 67 visibility_gap_timeout_ = base::TimeDelta::FromSeconds(timeout_seconds);
68 } 68 }
69 69
70 } // namespace metrics 70 } // namespace metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698