Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2292973002:
Backtrace related symbols must be included for uclibc (Closed)
Descriptionuclibc now has support for backtrace and demangle functions
BUG=
Committed: https://crrev.com/26c5b8fa1e79fc2fdbead52e9cfc5ca56b411343
Cr-Commit-Position: refs/heads/master@{#39263}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Guard demangle symbols with V8_LIBC_UCLIBC #Messages
Total messages: 20 (8 generated)
Description was changed from ========== Backtrace related symbols must be included for uclibc backtrace and backtrace_symbols is declared in execinfo.h BUG= ========== to ========== Backtrace related symbols must be included for uclibc backtrace and backtrace_symbols is declared in execinfo.h BUG= ==========
@reviewers, PTAL
rmcilroy@chromium.org changed reviewers: + rmcilroy@chromium.org
LGTM with a suggestion. (also you never added anyone as a reviewer, just on CC). https://codereview.chromium.org/2292973002/diff/1/src/base/debug/stack_trace_... File src/base/debug/stack_trace_posix.cc (right): https://codereview.chromium.org/2292973002/diff/1/src/base/debug/stack_trace_... src/base/debug/stack_trace_posix.cc:80: #if V8_LIBC_GLIBC || V8_OS_BSD Are you also able to compile this block of code with ublibc?
https://codereview.chromium.org/2292973002/diff/1/src/base/debug/stack_trace_... File src/base/debug/stack_trace_posix.cc (right): https://codereview.chromium.org/2292973002/diff/1/src/base/debug/stack_trace_... src/base/debug/stack_trace_posix.cc:80: #if V8_LIBC_GLIBC || V8_OS_BSD On 2016/09/05 10:33:49, rmcilroy wrote: > Are you also able to compile this block of code with ublibc? Actually I am. Seems as this is related to cxxabi.h rather than execinfo.h though and seems like cxxabi.h is part of gcc, rather than glibc/uclibc. We have a custom made toolchain so I am not sure that this would work for every uclibc platform. In any case, it works for me so if you want me I can make similar change here as well.
https://codereview.chromium.org/2292973002/diff/1/src/base/debug/stack_trace_... File src/base/debug/stack_trace_posix.cc (right): https://codereview.chromium.org/2292973002/diff/1/src/base/debug/stack_trace_... src/base/debug/stack_trace_posix.cc:80: #if V8_LIBC_GLIBC || V8_OS_BSD On 2016/09/05 11:39:28, landell wrote: > On 2016/09/05 10:33:49, rmcilroy wrote: > > Are you also able to compile this block of code with ublibc? > > Actually I am. Seems as this is related to cxxabi.h rather than execinfo.h > though and seems like cxxabi.h is part of gcc, rather than glibc/uclibc. > We have a custom made toolchain so I am not sure that this would work for every > uclibc platform. > > In any case, it works for me so if you want me I can make similar change here as > well. It would be good to keep it consistent, so please change it here too (also change the #endif comment on line 117).
https://codereview.chromium.org/2292973002/diff/1/src/base/debug/stack_trace_... File src/base/debug/stack_trace_posix.cc (right): https://codereview.chromium.org/2292973002/diff/1/src/base/debug/stack_trace_... src/base/debug/stack_trace_posix.cc:80: #if V8_LIBC_GLIBC || V8_OS_BSD On 2016/09/05 14:00:17, rmcilroy wrote: > On 2016/09/05 11:39:28, landell wrote: > > On 2016/09/05 10:33:49, rmcilroy wrote: > > > Are you also able to compile this block of code with ublibc? > > > > Actually I am. Seems as this is related to cxxabi.h rather than execinfo.h > > though and seems like cxxabi.h is part of gcc, rather than glibc/uclibc. > > We have a custom made toolchain so I am not sure that this would work for > every > > uclibc platform. > > > > In any case, it works for me so if you want me I can make similar change here > as > > well. > > It would be good to keep it consistent, so please change it here too (also > change the #endif comment on line 117). Done.
LGTM, thanks.
Description was changed from ========== Backtrace related symbols must be included for uclibc backtrace and backtrace_symbols is declared in execinfo.h BUG= ========== to ========== uclibc now has support for backtrace and demangle functions BUG= ==========
The CQ bit was checked by landell@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...) v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
The CQ bit was checked by landell@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== uclibc now has support for backtrace and demangle functions BUG= ========== to ========== uclibc now has support for backtrace and demangle functions BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== uclibc now has support for backtrace and demangle functions BUG= ========== to ========== uclibc now has support for backtrace and demangle functions BUG= Committed: https://crrev.com/26c5b8fa1e79fc2fdbead52e9cfc5ca56b411343 Cr-Commit-Position: refs/heads/master@{#39263} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/26c5b8fa1e79fc2fdbead52e9cfc5ca56b411343 Cr-Commit-Position: refs/heads/master@{#39263} |
