Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2332893002: Changes ownership of ScreenDimmer (Closed)

Created:
4 years, 3 months ago by sky
Modified:
4 years, 3 months ago
Reviewers:
oshima
CC:
chromium-reviews, alemate+watch_chromium.org, sadrul, hashimoto+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes ownership of ScreenDimmer This patch makes ScreenDimmer owned by the person using it, not the container. BUG=640781 TEST=covered by tests R=oshima@chromium.org Committed: https://crrev.com/1b5d58b7ce8d0f436e0c2c06e90cd548b3a770a3 Cr-Commit-Position: refs/heads/master@{#418110}

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : merge to tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -92 lines) Patch
M ash/wm/screen_dimmer.h View 1 4 chunks +10 lines, -16 lines 0 comments Download
M ash/wm/screen_dimmer.cc View 3 chunks +14 lines, -50 lines 0 comments Download
M ash/wm/screen_dimmer_unittest.cc View 5 chunks +13 lines, -15 lines 0 comments Download
M chrome/browser/chromeos/dbus/chrome_display_power_service_provider_delegate.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/dbus/chrome_display_power_service_provider_delegate.cc View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 3 chunks +12 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sky
4 years, 3 months ago (2016-09-12 18:14:28 UTC) #1
oshima
lgtm
4 years, 3 months ago (2016-09-12 22:17:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332893002/40001
4 years, 3 months ago (2016-09-12 23:14:29 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-12 23:57:57 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 00:01:23 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1b5d58b7ce8d0f436e0c2c06e90cd548b3a770a3
Cr-Commit-Position: refs/heads/master@{#418110}

Powered by Google App Engine
This is Rietveld 408576698