Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in canonicalPosition

Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in canonicalPosition

BUG=590369
Committed: https://crrev.com/5b063f4100b552bf982465635c5179f5d3569f9b
Cr-Commit-Position: refs/heads/master@{#417916}

[Xiaocheng, 2016-09-12 09:01:13]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 09:01:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-09-12 09:18:59]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-09-12 09:19:00]

PTAL.

[yosin_UTC9, 2016-09-12 09:25:03]

lgtm

https://codereview.chromium.org/2332723002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (right):

https://codereview.chromium.org/2332723002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/VisibleUnits.cpp:1243: if
(position1.position().document() != position2.position().document())
Could you change this to DCHEC_EQ(position1.position().document(),
position2.position().document())?

[Xiaocheng, 2016-09-12 09:36:21]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-09-12 09:36:22]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2332723002/#ps20001
(title: "Change if to DCHECK")

[commit-bot: I haz the power, 2016-09-12 09:36:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 11:02:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-12 11:04:24]

Description was changed from

==========
Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in
canonicalPosition

BUG=590369
==========

to

==========
Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in
canonicalPosition

BUG=590369

Committed: https://crrev.com/5b063f4100b552bf982465635c5179f5d3569f9b
Cr-Commit-Position: refs/heads/master@{#417916}
==========

[commit-bot: I haz the power, 2016-09-12 11:04:25]

Patchset 2 (id:??) landed as
https://crrev.com/5b063f4100b552bf982465635c5179f5d3569f9b
Cr-Commit-Position: refs/heads/master@{#417916}

[Xiaocheng, 2016-09-12 11:20:49]

https://codereview.chromium.org/2332723002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/VisibleUnits.cpp (right):

https://codereview.chromium.org/2332723002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/VisibleUnits.cpp:1243: if
(position1.position().document() != position2.position().document())
On 2016/09/12 at 09:25:03, Yosi_UTC9 wrote:
> Could you change this to DCHEC_EQ(position1.position().document(),
position2.position().document())?

Done.

Haven't found any call site that may compare two positions in different
documents. And it's also weird if there is any.