Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issue 2330953002: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in inSameLine (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in inSameLine BUG=590369 Committed: https://crrev.com/d5a658f547e994cbf85379878361af501bcbf879 Cr-Commit-Position: refs/heads/master@{#418148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleUnits.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
Xiaocheng
PTAL. Can I assume that a function with a |VisiblePosition| parameter must be called with ...
4 years, 3 months ago (2016-09-12 11:31:04 UTC) #4
yosin_UTC9
lgtm On 2016/09/12 at 11:31:04, xiaochengh wrote: > PTAL. > > Can I assume that ...
4 years, 3 months ago (2016-09-13 01:40:33 UTC) #7
Xiaocheng
On 2016/09/13 at 01:40:33, yosin wrote: > lgtm > > On 2016/09/12 at 11:31:04, xiaochengh ...
4 years, 3 months ago (2016-09-13 02:01:41 UTC) #8
tkent
lgtm
4 years, 3 months ago (2016-09-13 02:07:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2330953002/1
4 years, 3 months ago (2016-09-13 02:47:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-13 02:51:43 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 02:53:48 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d5a658f547e994cbf85379878361af501bcbf879
Cr-Commit-Position: refs/heads/master@{#418148}

Powered by Google App Engine
This is Rietveld 408576698