Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: chrome/browser/media/webrtc/media_stream_infobar_delegate_android.cc

Issue 2332663002: Revert of Enable the optional permission prompt persistence toggle on grouped infobars (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permission-infobardelegate-clean
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc/media_stream_infobar_delegate_android.cc
diff --git a/chrome/browser/media/webrtc/media_stream_infobar_delegate_android.cc b/chrome/browser/media/webrtc/media_stream_infobar_delegate_android.cc
index a096927938f8b005594c893d51d01356aed774fb..19dc2a0988eb73df21d793fe5d3300725ba867b5 100644
--- a/chrome/browser/media/webrtc/media_stream_infobar_delegate_android.cc
+++ b/chrome/browser/media/webrtc/media_stream_infobar_delegate_android.cc
@@ -11,7 +11,6 @@
#include "base/metrics/histogram_macros.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/infobars/infobar_service.h"
-#include "chrome/browser/permissions/permission_uma_util.h"
#include "chrome/common/url_constants.h"
#include "components/content_settings/core/common/content_settings_types.h"
#include "components/google/core/browser/google_util.h"
@@ -70,24 +69,6 @@
return true;
}
-void MediaStreamInfoBarDelegateAndroid::RecordPermissionAcceptedUma(
- int position,
- bool persist) {
- PermissionUmaUtil::PermissionPromptAcceptedWithPersistenceToggle(
- controller_->GetPermissionTypeForContentSettingsType(
- GetContentSettingType(position)),
- persist);
-}
-
-void MediaStreamInfoBarDelegateAndroid::RecordPermissionDeniedUma(
- int position,
- bool persist) {
- PermissionUmaUtil::PermissionPromptDeniedWithPersistenceToggle(
- controller_->GetPermissionTypeForContentSettingsType(
- GetContentSettingType(position)),
- persist);
-}
-
infobars::InfoBarDelegate::InfoBarIdentifier
MediaStreamInfoBarDelegateAndroid::GetIdentifier() const {
return MEDIA_STREAM_INFOBAR_DELEGATE_ANDROID;
@@ -115,24 +96,6 @@
}
bool MediaStreamInfoBarDelegateAndroid::Accept() {
- bool persist_permission = true;
- if (ShouldShowPersistenceToggle()) {
- persist_permission = persist();
-
- // TODO(dominickn): fold these metrics calls into
- // PermissionUmaUtil::PermissionGranted. See crbug.com/638076.
- if (GetPermissionCount() == 2) {
- RecordPermissionAcceptedUma(kGroupedInfobarAudioPosition,
- persist_permission);
- RecordPermissionAcceptedUma(kGroupedInfobarVideoPosition,
- persist_permission);
- } else {
- DCHECK_EQ(1, GetPermissionCount());
- RecordPermissionAcceptedUma(0, persist_permission);
- }
- }
-
- controller_->set_persist(persist_permission);
if (GetPermissionCount() == 2) {
controller_->GroupedRequestFinished(
GetAcceptState(kGroupedInfobarAudioPosition),
@@ -145,23 +108,6 @@
}
bool MediaStreamInfoBarDelegateAndroid::Cancel() {
- bool persist_permission = true;
- if (ShouldShowPersistenceToggle()) {
- persist_permission = persist();
-
- // TODO(dominickn): fold these metrics calls into
- // PermissionUmaUtil::PermissionGranted. See crbug.com/638076.
- if (GetPermissionCount() == 2) {
- RecordPermissionDeniedUma(kGroupedInfobarAudioPosition,
- persist_permission);
- RecordPermissionDeniedUma(kGroupedInfobarVideoPosition,
- persist_permission);
- } else {
- DCHECK_EQ(1, GetPermissionCount());
- RecordPermissionDeniedUma(0, persist_permission);
- }
- }
- controller_->set_persist(persist_permission);
controller_->PermissionDenied();
return true;
}

Powered by Google App Engine
This is Rietveld 408576698