Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2332663002: Revert of Enable the optional permission prompt persistence toggle on grouped infobars (Closed)

Created:
4 years, 3 months ago by dominickn
Modified:
4 years, 3 months ago
Reviewers:
kcarattini, xhwang, raymes, gone
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, dfalcantara+watch_chromium.org, Sergey Ulanov
Base URL:
https://chromium.googlesource.com/chromium/src.git@permission-infobardelegate-clean
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable the optional permission prompt persistence toggle on grouped infobars (patchset #13 id:240001 of https://codereview.chromium.org/2254763002/ ) Reason for revert: This still breaks the Android Tests bot. https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/31799 Original issue's description: > Enable the optional permission prompt persistence toggle on grouped infobars > > This CL adds support for the feature enabling a persistence toggle on > permission prompts to grouped permission infobars. The toggle is only > shown if an enabling feature is active. Grouped bars are used exclusively > for media permissions, so this change allows the toggle to be shown > when a single and multiple media permissions are requested. > > New Android UI tests for responding to the permission prompts triggered > by getUserMedia are added to verify the toggle behaviour. The persistence > boolean in media_stream_devices_controller is renamed in preparation for > upstreaming it into PermissionRequest. > > BUG=632269 > > Committed: https://crrev.com/fea9c39c10d391e8b03b77b39b889c54a96a9b5c > Committed: https://crrev.com/c23b2a5192ee77dd842b3e79575d586743364b32 > Cr-Original-Commit-Position: refs/heads/master@{#413970} > Cr-Commit-Position: refs/heads/master@{#417870} TBR=dfalcantara@chromium.org,raymes@chromium.org,kcarattini@chromium.org,xhwang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=632269 Committed: https://crrev.com/a4aa0cdb2175ab6d20b9eb4cef009710c14b77ee Cr-Commit-Position: refs/heads/master@{#417881}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -421 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/GroupedPermissionInfoBar.java View 5 chunks +6 lines, -16 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionInfoBar.java View 4 chunks +15 lines, -5 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/MediaPermissionsTest.java View 1 chunk +0 lines, -244 lines 0 comments Download
M chrome/browser/media/webrtc/media_stream_devices_controller.h View 4 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/media/webrtc/media_stream_devices_controller.cc View 6 chunks +15 lines, -18 lines 0 comments Download
M chrome/browser/media/webrtc/media_stream_infobar_delegate_android.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/media/webrtc/media_stream_infobar_delegate_android.cc View 4 chunks +0 lines, -54 lines 0 comments Download
M chrome/browser/permissions/grouped_permission_infobar_delegate.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/permissions/grouped_permission_infobar_delegate.cc View 2 chunks +1 line, -7 lines 0 comments Download
M chrome/browser/ui/android/infobars/grouped_permission_infobar.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/android/infobars/grouped_permission_infobar.cc View 2 chunks +1 line, -14 lines 0 comments Download
D content/test/data/android/media_permissions.html View 1 chunk +0 lines, -41 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dominickn
Created Revert of Enable the optional permission prompt persistence toggle on grouped infobars
4 years, 3 months ago (2016-09-12 07:00:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332663002/1
4 years, 3 months ago (2016-09-12 07:00:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 07:01:08 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a4aa0cdb2175ab6d20b9eb4cef009710c14b77ee Cr-Commit-Position: refs/heads/master@{#417881}
4 years, 3 months ago (2016-09-12 07:02:23 UTC) #7
kjellander_chromium
On 2016/09/12 07:02:23, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 3 months ago (2016-09-12 07:10:33 UTC) #8
kjellander_chromium
4 years, 3 months ago (2016-09-12 07:11:35 UTC) #9
Message was sent while issue was closed.
On 2016/09/12 07:10:33, kjellander_chromium wrote:
> On 2016/09/12 07:02:23, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/a4aa0cdb2175ab6d20b9eb4cef009710c14b77ee
> > Cr-Commit-Position: refs/heads/master@{#417881}
> 
> Thanks for this (I'm EMEA sheriff)

(it also broke Linux Tests and Chrome OS testers)

Powered by Google App Engine
This is Rietveld 408576698