third_party/harfbuzz-ng/harfbuzz.gyp - Issue 233263002: make it possible to set use_system_harfbuzz from outside

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/harfbuzz-ng/harfbuzz.gyp

Issue 233263002: make it possible to set use_system_harfbuzz from outside (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/harfbuzz-ng/harfbuzz.gyp

diff --git a/third_party/harfbuzz-ng/harfbuzz.gyp b/third_party/harfbuzz-ng/harfbuzz.gyp

index 7bd7d1d8b360872a8ce316fcf090a7817d2a831e..087e3dc88b11df62568a8945dbb0940b5e69b15a 100644

--- a/third_party/harfbuzz-ng/harfbuzz.gyp

+++ b/third_party/harfbuzz-ng/harfbuzz.gyp

@@ -26,7 +26,7 @@

# we use, so don't use system harfbuzz for official builds, unless we

# are building for chrome os, where we have the system harfbuzz under

# control as well.

- 'use_system_harfbuzz': '<!(python ../../build/check_return_value.py <(pkg-config) --atleast-version=1.31.0 pangoft2)',

+ 'use_system_harfbuzz%': '<!(python ../../build/check_return_value.py <(pkg-config) --atleast-version=1.31.0 pangoft2)',

}, {

'use_system_harfbuzz': 0,

Paweł Hajdan Jr. 2014/04/10 14:49:01 Consider also changing this one for consistency.

Mostyn Bramley-Moore 2014/04/10 15:00:49 I figure that you might want buildtype=="Official"

}],

« no previous file with comments | « no previous file | no next file » | no next file with comments »