make it possible to set use_system_harfbuzz from outside

third_party/harfbuzz-ng/harfbuzz.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'includes': [
     '../../build/win_precompile.gypi',
   ],
   'variables': {
     'variables': {
       'conditions': [
         ['sysroot!=""', {
           'pkg-config': '<(chroot_cmd) ../../build/linux/pkg-config-wrapper "<(sysroot)" "<(target_arch)"',
         }, {
           'pkg-config': 'pkg-config'
         }],
       ],
     },
 
     'pkg-config': '<(pkg-config)',
 
     'conditions': [
       ['OS=="linux" and (buildtype!="Official" or chromeos==1)', {
         # Since version 1.31.0, pangoft2 which we depend on pulls in harfbuzz
         # anyways. However, we want to have control of the version of harfbuzz
         # we use, so don't use system harfbuzz for official builds, unless we
         # are building for chrome os, where we have the system harfbuzz under
         # control as well.
-        'use_system_harfbuzz': '<!(python ../../build/check_return_value.py <(pkg-config) --atleast-version=1.31.0 pangoft2)',
+        'use_system_harfbuzz%': '<!(python ../../build/check_return_value.py <(pkg-config) --atleast-version=1.31.0 pangoft2)',
       }, {
         'use_system_harfbuzz': 0,

[Paweł Hajdan Jr., 2014/04/10 14:49:01]

Consider also changing this one for consistency.

[Mostyn Bramley-Moore, 2014/04/10 15:00:49]

I figure that you might want buildtype=="Official" to enforce certain settings,
but I don't know if that's something google wants/does.

       }],
     ],
   },
   'conditions': [
     ['use_system_harfbuzz==0', {
       'targets': [
         {
           'target_name': 'harfbuzz-ng',
           'type': 'static_library',
           'defines': [
@@ skipping 149 matching lines @@
             ],
             'libraries': [
               '<!@(<(pkg-config) --libs-only-l harfbuzz)',
             ],
           },
         },
       ],
     }],
   ],
 }