Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2332553002: Walk the entire offsetParent chain in fast/forms/resources/common.js utility functions. (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Walk the entire offsetParent chain in fast/forms/resources/common.js utility functions. They used to assume that the only offsetParent was the root node, but that's no longer going to be true when https://codereview.chromium.org/2328633003/ lands. One test that calls searchCancelButtonPosition() is inside a transformed element, which will become an offsetParent. R=tkent@chromium.org Committed: https://crrev.com/a7659ced0a27aec0d0f16932c94fce0453b91f73 Cr-Commit-Position: refs/heads/master@{#417893}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/fast/forms/resources/common.js View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mstensho (USE GERRIT)
4 years, 3 months ago (2016-09-10 17:14:15 UTC) #5
tkent
lgtm
4 years, 3 months ago (2016-09-12 03:49:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332553002/1
4 years, 3 months ago (2016-09-12 07:06:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 08:18:18 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 08:20:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7659ced0a27aec0d0f16932c94fce0453b91f73
Cr-Commit-Position: refs/heads/master@{#417893}

Powered by Google App Engine
This is Rietveld 408576698