Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 2328633003: A container of out-of-flow positioned descendants should be an offsetParent. (Closed)

Created:
4 years, 3 months ago by mstensho (USE GERRIT)
Modified:
4 years, 3 months ago
Reviewers:
Xianzhu, rune
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

A container of out-of-flow positioned descendants should be an offsetParent. This reflects a recent spec change [1]. Previously, the condition was that the position property be different from 'static', but it's unreasonable that we shouldn't also include other objects that serve as containing blocks for fixed and absolutely positioned descendants, such as "transform". Gecko and Edge already have this behavior. [1] https://github.com/w3c/csswg-drafts/commit/180b348a1ac0931043cd195651fc5164463d2bce BUG=645397 Committed: https://crrev.com/69f0712961a7ec8aedcd3ee724fa23c1aa8175fc Cr-Commit-Position: refs/heads/master@{#417903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/dom/Element/offset-parent-contain.html View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/Element/offset-parent-transform.html View 1 chunk +11 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/Element/offset-parent-will-change.html View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
mstensho (USE GERRIT)
4 years, 3 months ago (2016-09-12 09:44:53 UTC) #10
rune
lgtm
4 years, 3 months ago (2016-09-12 09:49:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328633003/1
4 years, 3 months ago (2016-09-12 09:51:21 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 09:54:41 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 09:56:38 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/69f0712961a7ec8aedcd3ee724fa23c1aa8175fc
Cr-Commit-Position: refs/heads/master@{#417903}

Powered by Google App Engine
This is Rietveld 408576698