Use new BoringSSL scopers in //crypto

Use new BoringSSL scopers in //crypto

Forward-declare with openssl/base.h which generally works nicer.
However this does require we take better care around public_deps
and some IWYU errors had to be fixed.

BUG=none
TBR=btolsch@chromium.org

Committed: https://crrev.com/74f6744bad3f658318d9efa1c9aae52d5bb2746f
Cr-Commit-Position: refs/heads/master@{#422260}

[davidben, 2016-09-09 23:10:23]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 23:10:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 23:17:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 23:18:00]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[davidben, 2016-09-09 23:24:41]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 23:24:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 23:46:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 23:46:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[davidben, 2016-09-10 00:15:49]

deps

[davidben, 2016-09-10 00:29:39]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 00:30:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 00:46:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 00:46:54]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[davidben, 2016-09-13 18:00:33]

IWYU

[davidben, 2016-09-13 18:44:03]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 18:44:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 19:06:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 19:06:06]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[davidben, 2016-09-13 20:58:33]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[davidben, 2016-09-13 20:58:59]

Description was changed from

==========
Use new BoringSSL scopers in crypto::ECPrivateKey.

For now just doing one for try job purposes.

BUG=
==========

to

==========
Use new BoringSSL scopers in crypto::{RSA,EC}PrivateKey.

Just convert a few for now.

BUG=
==========

[commit-bot: I haz the power, 2016-09-13 20:59:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 22:29:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 22:29:40]

Dry run: This issue passed the CQ dry run.

[davidben, 2016-09-22 23:07:11]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 23:07:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidben, 2016-09-22 23:07:43]

Description was changed from

==========
Use new BoringSSL scopers in crypto::{RSA,EC}PrivateKey.

Just convert a few for now.

BUG=
==========

to

==========
Use new BoringSSL scopers in //crypto

BUG=none
==========

[davidben, 2016-09-22 23:07:43]

davidben@chromium.org changed reviewers:
+ rsleevi@chromium.org

[commit-bot: I haz the power, 2016-09-22 23:18:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 23:18:47]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Ryan Sleevi, 2016-09-22 23:27:14]

Ping when bots are green? :) Will easily rubberstamp and CQ then :)

[davidben, 2016-09-23 22:34:36]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 22:35:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 22:45:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 22:45:17]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[davidben, 2016-09-23 22:49:47]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 22:50:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[davidben, 2016-09-23 22:54:54]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 22:55:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 23:07:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 23:07:32]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[davidben, 2016-09-23 23:12:41]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 23:13:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 23:22:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 23:22:44]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[davidben, 2016-09-23 23:24:19]

The CQ bit was checked by davidben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 23:24:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-24 00:52:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-24 00:52:56]

Dry run: This issue passed the CQ dry run.

[davidben, 2016-09-24 00:58:26]

Description was changed from

==========
Use new BoringSSL scopers in //crypto

BUG=none
==========

to

==========
Use new BoringSSL scopers in //crypto

Forward-declare with openssl/base.h which generally works nicer.
However this does require we take better care around public_deps
and some IWYU errors had to be fixed.

BUG=none
==========

[davidben, 2016-09-24 00:58:36]

After many iterations, it's green now.

[Ryan Sleevi, 2016-09-24 01:02:49]

lgtm

https://codereview.chromium.org/2332473002/diff/200001/crypto/ec_private_key.h
File crypto/ec_private_key.h (right):

https://codereview.chromium.org/2332473002/diff/200001/crypto/ec_private_key....
crypto/ec_private_key.h:8: #include <openssl/base.h>
Is it still on your radar to 'third-partify' this? :)

[Ryan Sleevi, 2016-09-24 01:03:14]

Also, sadly, I can't CQ because I'm not sufficient OWNERS, but this should be
fine to TBR

[davidben, 2016-09-26 21:02:17]

davidben@chromium.org changed reviewers:
+ michaelbai@chromium.org, sorin@chromium.org, wez@chromium.org

[davidben, 2016-09-26 21:02:18]

+sorin for components/update_client/OWNERS
+wez for extensions/browser/api/cast_channel/OWNERS
+michaelbai for android_webview/OWNERS

[Sorin Jianu, 2016-09-26 21:25:06]

lgtm

Thank you! Component updater paths lgtm.

[michaelbai, 2016-09-26 21:33:30]

https://codereview.chromium.org/2332473002/diff/200001/android_webview/BUILD.gn
File android_webview/BUILD.gn (right):

https://codereview.chromium.org/2332473002/diff/200001/android_webview/BUILD....
android_webview/BUILD.gn:658: "//crypto",
sorry, don't understand this change, why it is not required before?

[davidben, 2016-09-26 21:42:00]

https://codereview.chromium.org/2332473002/diff/200001/android_webview/BUILD.gn
File android_webview/BUILD.gn (right):

https://codereview.chromium.org/2332473002/diff/200001/android_webview/BUILD....
android_webview/BUILD.gn:658: "//crypto",
On 2016/09/26 21:33:30, michaelbai wrote:
> sorry, don't understand this change, why it is not required before?

A number of files in android_webview depend on crypto::ECPrivateKey directly,
which means the targets should directly depend on //crypto. It happened to work
because other targets were pulling it in and our buildsystem doesn't enforce
#includes. BoringSSL is right now still included funny via a system-style
include even though we're not system library (I'm intending to fix this though),
which has the side effect of sometime hitting dependency errors like this one.

[michaelbai, 2016-09-26 21:44:18]

thanks for the explanation, android_webview LGTM

[Wez, 2016-09-27 17:26:41]

wez@chromium.org changed reviewers:
+ btolsch@chromium.org
- wez@chromium.org

[Wez, 2016-09-27 17:26:42]

-wez, +btolsch, since he's been working on CastChannel more recently. :)

[davidben, 2016-09-29 20:22:37]

btolsch => TBR per #53 since this is a trivial fixup of dependencies.

[davidben, 2016-09-29 20:22:49]

Description was changed from

==========
Use new BoringSSL scopers in //crypto

Forward-declare with openssl/base.h which generally works nicer.
However this does require we take better care around public_deps
and some IWYU errors had to be fixed.

BUG=none
==========

to

==========
Use new BoringSSL scopers in //crypto

Forward-declare with openssl/base.h which generally works nicer.
However this does require we take better care around public_deps
and some IWYU errors had to be fixed.

BUG=none
TBR=btolsch@chromium.org
==========

[davidben, 2016-09-29 20:22:55]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2016-09-29 20:23:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 20:25:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 20:25:42]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[davidben, 2016-09-30 21:30:00]

The CQ bit was checked by davidben@chromium.org

[davidben, 2016-09-30 21:30:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelbai@chromium.org, sorin@chromium.org, rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/2332473002/#ps220001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-30 21:30:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 23:39:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 23:39:57]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[davidben, 2016-09-30 23:40:58]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2016-09-30 23:41:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-01 01:48:49]

Description was changed from

==========
Use new BoringSSL scopers in //crypto

Forward-declare with openssl/base.h which generally works nicer.
However this does require we take better care around public_deps
and some IWYU errors had to be fixed.

BUG=none
TBR=btolsch@chromium.org
==========

to

==========
Use new BoringSSL scopers in //crypto

Forward-declare with openssl/base.h which generally works nicer.
However this does require we take better care around public_deps
and some IWYU errors had to be fixed.

BUG=none
TBR=btolsch@chromium.org
==========

[commit-bot: I haz the power, 2016-10-01 01:48:51]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2016-10-01 01:52:26]

Description was changed from

==========
Use new BoringSSL scopers in //crypto

Forward-declare with openssl/base.h which generally works nicer.
However this does require we take better care around public_deps
and some IWYU errors had to be fixed.

BUG=none
TBR=btolsch@chromium.org
==========

to

==========
Use new BoringSSL scopers in //crypto

Forward-declare with openssl/base.h which generally works nicer.
However this does require we take better care around public_deps
and some IWYU errors had to be fixed.

BUG=none
TBR=btolsch@chromium.org

Committed: https://crrev.com/74f6744bad3f658318d9efa1c9aae52d5bb2746f
Cr-Commit-Position: refs/heads/master@{#422260}
==========

[commit-bot: I haz the power, 2016-10-01 01:52:28]

Patchset 12 (id:??) landed as
https://crrev.com/74f6744bad3f658318d9efa1c9aae52d5bb2746f
Cr-Commit-Position: refs/heads/master@{#422260}