Use new BoringSSL scopers in //crypto

android_webview/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/android/rules.gni")
 import("//build/config/locales.gni")
 import("//tools/grit/repack.gni")
 import("//tools/resources/generate_resource_whitelist.gni")
 import("system_webview_apk_tmpl.gni")
@@ skipping 637 matching lines @@
     "//components/supervised_user_error_page",
     "//components/supervised_user_error_page:gin",
     "//components/version_info",
     "//components/visitedlink/browser",
     "//components/visitedlink/renderer",
     "//components/web_contents_delegate_android:web_contents_delegate_android",
     "//components/web_restrictions:browser",
     "//content",
     "//content/public/app:both",
     "//content/public/browser",
+    "//crypto",

[michaelbai, 2016/09/26 21:33:30]

sorry, don't understand this change, why it is not required before?

[davidben, 2016/09/26 21:42:00]

A number of files in android_webview depend on crypto::ECPrivateKey directly,
which means the targets should directly depend on //crypto. It happened to work
because other targets were pulling it in and our buildsystem doesn't enforce
#includes. BoringSSL is right now still included funny via a system-style
include even though we're not system library (I'm intending to fix this though),
which has the side effect of sometime hitting dependency errors like this one.

     "//gin",
     "//gpu/command_buffer/client:gl_in_process_context",
     "//gpu/command_buffer/client:gles2_c_lib",
     "//gpu/command_buffer/client:gles2_implementation",
     "//gpu/command_buffer/common:gles2_utils",
     "//gpu/command_buffer/service",
     "//gpu/skia_bindings",
     "//media",
     "//media/midi",
     "//net:extras",
@@ skipping 172 matching lines @@
   system_webview_apk_tmpl("system_webview_apk") {
     android_manifest = system_webview_android_manifest
     android_manifest_dep = ":system_webview_manifest"
     deps = [
       ":system_webview_resources",
       "//android_webview/glue",
     ]
     apk_name = "SystemWebView"
   }
 }