mash: Remove shelf util functions; use WmWindow properties.

mash: Remove shelf util functions; use WmWindow properties.

Move aura window properties to WmWindowAura.
(towards supporting [Shelf]WindowWatcher in mash)

Cleanup ShelfItem and ShelfItemDetails structs.
Remove unused ash support for UserManagerView

BUG=634150
TEST=Automated tests; no shelf functionality changes.
R=sky@chromium.org

Committed: https://crrev.com/5b121135307b585ea60e1cd24d2f7cb75a7ee354
Cr-Commit-Position: refs/heads/master@{#418723}

[msw, 2016-09-14 20:34:23]

Description was changed from

==========
mash: Support shelf items via ShelfWindowWatcher.

BUG=634150
==========

to

==========
mash: Remove shelf util functions; use WmWindow properties.

Move aura window properties to WmWindowAura.
(towards supporting [Shelf]WindowWatcher in mash)

Cleanup ShelfItem and ShelfItemDetails structs.
Remove unused ash support for UserManagerView

BUG=634150
TEST=Automated tests; no shelf functionality changes.
R=sky@chromium.org
==========

[msw, 2016-09-14 20:34:24]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-09-14 20:35:48]

Hey Scott, please take a look; thanks!

[msw, 2016-09-14 20:35:53]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-14 20:36:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-09-14 21:34:12]

LGTM

[James Cook, 2016-09-14 22:07:10]

jamescook@chromium.org changed reviewers:
+ jamescook@chromium.org

[James Cook, 2016-09-14 22:07:10]

Some optional drive-by remarks.

https://codereview.chromium.org/2332393003/diff/40001/ash/common/shelf/shelf_...
File ash/common/shelf/shelf_item_types.h (right):

https://codereview.chromium.org/2332393003/diff/40001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_item_types.h:62: ShelfItemType type = TYPE_UNDEFINED;
aside: It's a bummer that the ash global namespace is polluted with
ash::TYPE_UNDEFINED.

If there's a future CL that touches a bunch of references to the ShelfItemType
enum that might be a good time to switch to enum class.

https://codereview.chromium.org/2332393003/diff/40001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_item_types.h:65: gfx::ImageSkia image;
optional: Given that ImageSkia has a non-trivial constructor, do you think it's
worth preserving the .cc file and having a non-inlined constructor for this
class?

I'm not sure what our threshold is.

https://codereview.chromium.org/2332393003/diff/40001/ash/shelf/shelf_util.h
File ash/shelf/shelf_util.h (left):

https://codereview.chromium.org/2332393003/diff/40001/ash/shelf/shelf_util.h#...
ash/shelf/shelf_util.h:39: ASH_EXPORT void
SetShelfItemDetailsForWindow(aura::Window* window,
I'm so glad all these bare functions are gone.

[commit-bot: I haz the power, 2016-09-14 22:19:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 22:19:25]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[msw, 2016-09-14 22:29:15]

https://codereview.chromium.org/2332393003/diff/40001/ash/common/shelf/shelf_...
File ash/common/shelf/shelf_item_types.h (right):

https://codereview.chromium.org/2332393003/diff/40001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_item_types.h:62: ShelfItemType type = TYPE_UNDEFINED;
On 2016/09/14 22:07:10, James Cook wrote:
> aside: It's a bummer that the ash global namespace is polluted with
> ash::TYPE_UNDEFINED.
> 
> If there's a future CL that touches a bunch of references to the ShelfItemType
> enum that might be a good time to switch to enum class.

Acknowledged.

https://codereview.chromium.org/2332393003/diff/40001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_item_types.h:65: gfx::ImageSkia image;
On 2016/09/14 22:07:10, James Cook wrote:
> optional: Given that ImageSkia has a non-trivial constructor, do you think
it's
> worth preserving the .cc file and having a non-inlined constructor for this
> class?
> 
> I'm not sure what our threshold is.

Done.

https://codereview.chromium.org/2332393003/diff/40001/ash/shelf/shelf_util.h
File ash/shelf/shelf_util.h (left):

https://codereview.chromium.org/2332393003/diff/40001/ash/shelf/shelf_util.h#...
ash/shelf/shelf_util.h:39: ASH_EXPORT void
SetShelfItemDetailsForWindow(aura::Window* window,
On 2016/09/14 22:07:10, James Cook wrote:
> I'm so glad all these bare functions are gone.

Acknowledged.

[msw, 2016-09-14 22:29:20]

The CQ bit was checked by msw@chromium.org

[msw, 2016-09-14 22:29:21]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2332393003/#ps60001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-09-14 22:30:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 00:24:40]

Description was changed from

==========
mash: Remove shelf util functions; use WmWindow properties.

Move aura window properties to WmWindowAura.
(towards supporting [Shelf]WindowWatcher in mash)

Cleanup ShelfItem and ShelfItemDetails structs.
Remove unused ash support for UserManagerView

BUG=634150
TEST=Automated tests; no shelf functionality changes.
R=sky@chromium.org
==========

to

==========
mash: Remove shelf util functions; use WmWindow properties.

Move aura window properties to WmWindowAura.
(towards supporting [Shelf]WindowWatcher in mash)

Cleanup ShelfItem and ShelfItemDetails structs.
Remove unused ash support for UserManagerView

BUG=634150
TEST=Automated tests; no shelf functionality changes.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-09-15 00:24:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-15 00:26:20]

Description was changed from

==========
mash: Remove shelf util functions; use WmWindow properties.

Move aura window properties to WmWindowAura.
(towards supporting [Shelf]WindowWatcher in mash)

Cleanup ShelfItem and ShelfItemDetails structs.
Remove unused ash support for UserManagerView

BUG=634150
TEST=Automated tests; no shelf functionality changes.
R=sky@chromium.org
==========

to

==========
mash: Remove shelf util functions; use WmWindow properties.

Move aura window properties to WmWindowAura.
(towards supporting [Shelf]WindowWatcher in mash)

Cleanup ShelfItem and ShelfItemDetails structs.
Remove unused ash support for UserManagerView

BUG=634150
TEST=Automated tests; no shelf functionality changes.
R=sky@chromium.org

Committed: https://crrev.com/5b121135307b585ea60e1cd24d2f7cb75a7ee354
Cr-Commit-Position: refs/heads/master@{#418723}
==========

[commit-bot: I haz the power, 2016-09-15 00:26:22]

Patchset 4 (id:??) landed as
https://crrev.com/5b121135307b585ea60e1cd24d2f7cb75a7ee354
Cr-Commit-Position: refs/heads/master@{#418723}