chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc - Issue 2332393003: mash: Remove shelf util functions; use WmWindow properties.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/ash/launcher/arc_app_launcher_browsertest.cc

Issue 2332393003: mash: Remove shelf util functions; use WmWindow properties. (Closed)

Patch Set: Address comments. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ash/common/shelf/shelf_delegate.h"	5 #include "ash/common/shelf/shelf_delegate.h"

6 #include "ash/common/wm_shell.h"	6 #include "ash/common/wm_shell.h"

7 #include "ash/shelf/shelf_util.h"

8 #include "ash/wm/window_util.h"	7 #include "ash/wm/window_util.h"

9 #include "base/macros.h"	8 #include "base/macros.h"

10 #include "base/run_loop.h"	9 #include "base/run_loop.h"

11 #include "chrome/browser/extensions/extension_browsertest.h"	10 #include "chrome/browser/extensions/extension_browsertest.h"

12 #include "chrome/browser/ui/app_list/app_list_service.h"	11 #include "chrome/browser/ui/app_list/app_list_service.h"

13 #include "chrome/browser/ui/app_list/app_list_syncable_service.h"	12 #include "chrome/browser/ui/app_list/app_list_syncable_service.h"

14 #include "chrome/browser/ui/app_list/app_list_syncable_service_factory.h"	13 #include "chrome/browser/ui/app_list/app_list_syncable_service_factory.h"

15 #include "chrome/browser/ui/app_list/arc/arc_app_list_prefs.h"	14 #include "chrome/browser/ui/app_list/arc/arc_app_list_prefs.h"

16 #include "chrome/browser/ui/app_list/arc/arc_app_utils.h"	15 #include "chrome/browser/ui/app_list/arc/arc_app_utils.h"

17 #include "chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h"	16 #include "chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_controller.h"

(...skipping 337 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
355 SendPackageAdded(true);	354 SendPackageAdded(true);

356 EXPECT_TRUE(app_list_service->IsAppListVisible());	355 EXPECT_TRUE(app_list_service->IsAppListVisible());

357	356

358 app_list_service->DismissAppList();	357 app_list_service->DismissAppList();

359 EXPECT_FALSE(app_list_service->IsAppListVisible());	358 EXPECT_FALSE(app_list_service->IsAppListVisible());

360	359

361 // Send package update event. App list is not shown.	360 // Send package update event. App list is not shown.

362 SendPackageAdded(true);	361 SendPackageAdded(true);

363 EXPECT_FALSE(app_list_service->IsAppListVisible());	362 EXPECT_FALSE(app_list_service->IsAppListVisible());

364 }	363 }

OLD	NEW