|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by lawrencewu Modified:
4 years, 3 months ago Reviewers:
Alexei Svitkine (slow) CC:
chromium-reviews, asvitkine+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove unnecessary comment in metrics code
BUG=637322
Committed: https://crrev.com/4582c72d65e363b1fa6be6e7842888fdfc8dfd1e
Cr-Commit-Position: refs/heads/master@{#418315}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Add more context in GUID retrieval failure comment #Messages
Total messages: 22 (14 generated)
Description was changed from ========== Remove unnecessary comment in metrics code BUG=637322 ========== to ========== Remove unnecessary comment in metrics code BUG=637322 ==========
lawrencewu@chromium.org changed reviewers: + asvitkine@chromium.org, rkaplow@chromium.org
The CQ bit was checked by lawrencewu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lawrencewu@chromium.org changed reviewers: - rkaplow@chromium.org
https://codereview.chromium.org/2332393002/diff/1/components/metrics/metrics_... File components/metrics/metrics_state_manager.cc (right): https://codereview.chromium.org/2332393002/diff/1/components/metrics/metrics_... components/metrics/metrics_state_manager.cc:264: // retrieval failed. If not, return nullptr and generate a new GUID. "and generate a new GUID" part of the comment is confusing, because that's not being done in this function. I suggest expanding the comment to give more context, like ". This will result in a new GUID being generated and backed up by the calling code FooBar()."
The CQ bit was checked by lawrencewu@chromium.org to run a CQ dry run
updated the patchset
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by lawrencewu@chromium.org
The CQ bit was checked by lawrencewu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by lawrencewu@chromium.org
The CQ bit was unchecked by lawrencewu@chromium.org
The CQ bit was checked by lawrencewu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove unnecessary comment in metrics code BUG=637322 ========== to ========== Remove unnecessary comment in metrics code BUG=637322 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove unnecessary comment in metrics code BUG=637322 ========== to ========== Remove unnecessary comment in metrics code BUG=637322 Committed: https://crrev.com/4582c72d65e363b1fa6be6e7842888fdfc8dfd1e Cr-Commit-Position: refs/heads/master@{#418315} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4582c72d65e363b1fa6be6e7842888fdfc8dfd1e Cr-Commit-Position: refs/heads/master@{#418315} |
