Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2332393002: Remove unnecessary comment in metrics code (Closed)

Created:
4 years, 3 months ago by lawrencewu
Modified:
4 years, 3 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary comment in metrics code BUG=637322 Committed: https://crrev.com/4582c72d65e363b1fa6be6e7842888fdfc8dfd1e Cr-Commit-Position: refs/heads/master@{#418315}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add more context in GUID retrieval failure comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M components/metrics/metrics_state_manager.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 22 (14 generated)
lawrencewu
4 years, 3 months ago (2016-09-13 17:36:26 UTC) #6
Alexei Svitkine (slow)
https://codereview.chromium.org/2332393002/diff/1/components/metrics/metrics_state_manager.cc File components/metrics/metrics_state_manager.cc (right): https://codereview.chromium.org/2332393002/diff/1/components/metrics/metrics_state_manager.cc#newcode264 components/metrics/metrics_state_manager.cc:264: // retrieval failed. If not, return nullptr and generate ...
4 years, 3 months ago (2016-09-13 17:38:36 UTC) #7
lawrencewu
updated the patchset
4 years, 3 months ago (2016-09-13 17:43:23 UTC) #9
Alexei Svitkine (slow)
lgtm
4 years, 3 months ago (2016-09-13 17:45:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332393002/20001
4 years, 3 months ago (2016-09-13 17:48:56 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332393002/20001
4 years, 3 months ago (2016-09-13 17:50:15 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-13 18:42:34 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 18:45:31 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4582c72d65e363b1fa6be6e7842888fdfc8dfd1e
Cr-Commit-Position: refs/heads/master@{#418315}

Powered by Google App Engine
This is Rietveld 408576698