Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: components/metrics/metrics_state_manager.cc

Issue 2332393002: Remove unnecessary comment in metrics code (Closed)
Patch Set: Add more context in GUID retrieval failure comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_state_manager.cc
diff --git a/components/metrics/metrics_state_manager.cc b/components/metrics/metrics_state_manager.cc
index ae0754e8ea1134b9e8ddcacca676ccb0c7772394..4cae20d3ae7be6df2815d0367e2e16d5998d86ba 100644
--- a/components/metrics/metrics_state_manager.cc
+++ b/components/metrics/metrics_state_manager.cc
@@ -261,10 +261,8 @@ MetricsStateManager::LoadClientInfoAndMaybeMigrate() {
}
// The GUID retrieved (and possibly fixed above) should be valid unless
- // retrieval failed.
- // DCHECK(!client_info || base::IsValidGUID(client_info->client_id));
- // Temporary hack for http://crbug.com/635255.
- // TODO(asvitkine): address this the right way.
+ // retrieval failed. If not, return nullptr. This will result in a new GUID
+ // being generated by the calling function ForceClientIdCreation().
if (client_info && !base::IsValidGUID(client_info->client_id))
return nullptr;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698