Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2332353006: Use NTPTileSource in MVS interface. (Closed)

Created:
4 years, 3 months ago by sfiera
Modified:
4 years, 3 months ago
Reviewers:
Marc Treib
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use NTPTileSource in MVS interface. MostVisitedSitesBridge can handle conversion between int and the enum for the sake of Java. Using the enum itself is better for iOS, and generally as an interface. Committed: https://crrev.com/b1815a338609f17686f54d66af9d7426c1893516 Cr-Commit-Position: refs/heads/master@{#418667}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use tile type enum too. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -21 lines) Patch
M chrome/browser/android/ntp/most_visited_sites_bridge.cc View 1 3 chunks +17 lines, -5 lines 0 comments Download
M components/ntp_tiles/most_visited_sites.h View 1 1 chunk +5 lines, -3 lines 0 comments Download
M components/ntp_tiles/most_visited_sites.cc View 1 4 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
sfiera
Another small one.
4 years, 3 months ago (2016-09-14 01:33:41 UTC) #5
Marc Treib
LGTM with one optional suggestion. https://codereview.chromium.org/2332353006/diff/1/components/ntp_tiles/most_visited_sites.h File components/ntp_tiles/most_visited_sites.h (right): https://codereview.chromium.org/2332353006/diff/1/components/ntp_tiles/most_visited_sites.h#newcode135 components/ntp_tiles/most_visited_sites.h:135: int tile_type, Also use ...
4 years, 3 months ago (2016-09-14 08:55:08 UTC) #8
sfiera
https://codereview.chromium.org/2332353006/diff/1/components/ntp_tiles/most_visited_sites.h File components/ntp_tiles/most_visited_sites.h (right): https://codereview.chromium.org/2332353006/diff/1/components/ntp_tiles/most_visited_sites.h#newcode135 components/ntp_tiles/most_visited_sites.h:135: int tile_type, On 2016/09/14 08:55:08, Marc Treib wrote: > ...
4 years, 3 months ago (2016-09-14 19:09:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2332353006/20001
4 years, 3 months ago (2016-09-14 20:37:21 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-14 20:52:35 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 20:54:02 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b1815a338609f17686f54d66af9d7426c1893516
Cr-Commit-Position: refs/heads/master@{#418667}

Powered by Google App Engine
This is Rietveld 408576698