Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/browser/android/ntp/most_visited_sites_bridge.cc

Issue 2332353006: Use NTPTileSource in MVS interface. (Closed)
Patch Set: Use tile type enum too. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/ntp_tiles/most_visited_sites.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/ntp/most_visited_sites_bridge.cc
diff --git a/chrome/browser/android/ntp/most_visited_sites_bridge.cc b/chrome/browser/android/ntp/most_visited_sites_bridge.cc
index 7c0676f30d28ac3eb89531dda8ec52e4e06c726b..d15b4b572912e6e5bba0d9d4da2b7555a311fc64 100644
--- a/chrome/browser/android/ntp/most_visited_sites_bridge.cc
+++ b/chrome/browser/android/ntp/most_visited_sites_bridge.cc
@@ -42,6 +42,7 @@ using base::android::ToJavaIntArray;
using content::BrowserThread;
using ntp_tiles::MostVisitedSites;
using ntp_tiles::MostVisitedSitesSupervisor;
+using ntp_tiles::NTPTileSource;
using suggestions::SuggestionsServiceFactory;
MostVisitedSitesBridge::SupervisorBridge::SupervisorBridge(Profile* profile)
@@ -205,11 +206,20 @@ void MostVisitedSitesBridge::RecordTileTypeMetrics(
const JavaParamRef<jobject>& obj,
const JavaParamRef<jintArray>& jtile_types,
const JavaParamRef<jintArray>& jsources) {
- std::vector<int> tile_types;
- std::vector<int> sources;
+ std::vector<int> int_tile_types;
+ base::android::JavaIntArrayToIntVector(env, jtile_types, &int_tile_types);
+ std::vector<MostVisitedSites::MostVisitedTileType> tile_types;
+ for (int source : int_tile_types) {
+ tile_types.push_back(
+ static_cast<MostVisitedSites::MostVisitedTileType>(source));
+ }
- base::android::JavaIntArrayToIntVector(env, jtile_types, &tile_types);
- base::android::JavaIntArrayToIntVector(env, jsources, &sources);
+ std::vector<int> int_sources;
+ base::android::JavaIntArrayToIntVector(env, jsources, &int_sources);
+ std::vector<NTPTileSource> sources;
+ for (int source : int_sources) {
+ sources.push_back(static_cast<NTPTileSource>(source));
+ }
most_visited_.RecordTileTypeMetrics(tile_types, sources);
}
@@ -220,7 +230,9 @@ void MostVisitedSitesBridge::RecordOpenedMostVisitedItem(
jint index,
jint tile_type,
jint source) {
- most_visited_.RecordOpenedMostVisitedItem(index, tile_type, source);
+ most_visited_.RecordOpenedMostVisitedItem(
+ index, static_cast<MostVisitedSites::MostVisitedTileType>(tile_type),
+ static_cast<NTPTileSource>(source));
}
// static
« no previous file with comments | « no previous file | components/ntp_tiles/most_visited_sites.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698