Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py

scripts/slave/recipes/chromium_codesearch.py

Index: scripts/slave/recipes/chromium_codesearch.py
diff --git a/scripts/slave/recipes/chromium_codesearch.py b/scripts/slave/recipes/chromium_codesearch.py
index 6fcb3e29366914cf39e78312408945b4802c5782..8fc59d47c96858796f6f55f91516a13ff955f44a 100644
--- a/scripts/slave/recipes/chromium_codesearch.py
+++ b/scripts/slave/recipes/chromium_codesearch.py
@@ -45,10 +45,8 @@ LINUX_GN_ARGS = [
   'is_clang=true',
   'is_component_build=true',
   'is_debug=true',
-  'goma_dir="/b/build/goma"',
   'symbol_level=1',
   'target_cpu="x64"',
-  'use_goma=true',
 ]
 
 CHROMEOS_GN_ARGS = LINUX_GN_ARGS + [
@@ -103,6 +101,8 @@ def GenerateCompilationDatabase(api, debug_path, targets, platform):
   # adjusted.
   gn_path = api.path['checkout'].join('buildtools', 'linux64', 'gn')
   args = LINUX_GN_ARGS if platform == 'linux' else CHROMEOS_GN_ARGS
+  args.extend(['use_goma=true',

[ukai, 2016/09/13 05:20:25]

ok to add this to CHROMEOS_GN_ARGS?

[tikuta, 2016/09/13 05:29:44]

I'm not sure, but CHROMEOS_GN_ARGS is made by adding some option to
LINUX_GN_ARGS, so it is OK?

[ukai, 2016/09/13 05:40:49]

ah, ok.

+               'goma_dir=%s' % api.chromium.c.compile_py.goma_dir])

[Yoshisato Yanagisawa, 2016/09/14 01:21:22]

It could be redundant but...
if we only judge the behavior with local code, it might be better to set
use_goma only if api.chromium.c.compile_py.goma_dir is not empty.

[tikuta, 2016/09/14 02:36:08]

Done.

   command = [gn_path, 'gen', debug_path, '--args=%s' % ' '.join(args)]
   api.step('generate build files for %s' % platform, command,
            cwd=api.path['checkout'])
@@ -140,6 +140,7 @@ def RunSteps(api):
   debug_path = api.path['checkout'].join('out', 'Debug')
   targets = bot_config.get('compile_targets', [])
   api.chromium.set_config('codesearch', BUILD_CONFIG='Debug')
+  api.chromium.ensure_goma()
   api.chromium.runhooks()
 
   result = GenerateCompilationDatabase(api, debug_path, targets, platform)