Use [CACHE]/cipd/goma for goma_dir in recipes/chromium_codesearch.py

scripts/slave/recipes/chromium_codesearch.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from recipe_engine.types import freeze
 
 DEPS = [
   'depot_tools/bot_update',
   'chromium',
   'commit_position',
@@ skipping 27 matching lines @@
   'tools/deps2git': '%s/chromium/tools/deps2git' % CHROMIUM_GIT_URL,
   'tools/gsd_generate_index':\
       '%s/chromium/tools/gsd_generate_index' % CHROMIUM_GIT_URL,
   'tools/perf': '%s/chromium/tools/perf' % CHROMIUM_GIT_URL,
 })
 
 LINUX_GN_ARGS = [
   'is_clang=true',
   'is_component_build=true',
   'is_debug=true',
-  'goma_dir="/b/build/goma"',
   'symbol_level=1',
   'target_cpu="x64"',
-  'use_goma=true',
 ]
 
 CHROMEOS_GN_ARGS = LINUX_GN_ARGS + [
   'target_os="chromeos"',
   'use_ozone=true',
 ]
 
 SPEC = freeze({
   # The builders have the following parameters:
   # - compile_targets: the compile targets.
@@ skipping 34 matching lines @@
       'platform': 'chromeos',
     },
   },
 })
 
 def GenerateCompilationDatabase(api, debug_path, targets, platform):
   # TODO(akuegel): If we ever build on Windows or Mac, this needs to be
   # adjusted.
   gn_path = api.path['checkout'].join('buildtools', 'linux64', 'gn')
   args = LINUX_GN_ARGS if platform == 'linux' else CHROMEOS_GN_ARGS
+  args.extend(['use_goma=true',

[ukai, 2016/09/13 05:20:25]

ok to add this to CHROMEOS_GN_ARGS?

[tikuta, 2016/09/13 05:29:44]

I'm not sure, but CHROMEOS_GN_ARGS is made by adding some option to
LINUX_GN_ARGS, so it is OK?

[ukai, 2016/09/13 05:40:49]

ah, ok.

+               'goma_dir=%s' % api.chromium.c.compile_py.goma_dir])

[Yoshisato Yanagisawa, 2016/09/14 01:21:22]

It could be redundant but...
if we only judge the behavior with local code, it might be better to set
use_goma only if api.chromium.c.compile_py.goma_dir is not empty.

[tikuta, 2016/09/14 02:36:08]

Done.

   command = [gn_path, 'gen', debug_path, '--args=%s' % ' '.join(args)]
   api.step('generate build files for %s' % platform, command,
            cwd=api.path['checkout'])
   command = ['ninja', '-C', debug_path] + list(targets)
   # Add the parameters for creating the compilation database.
   command += ['-t', 'compdb', 'cc', 'cxx', 'objc', 'objcxx']
   return api.step('generate compilation database for %s' % platform,
                   command,
                   stdout=api.raw_io.output())
 
@@ skipping 17 matching lines @@
 
   # Remove the llvm-build directory, so that gclient runhooks will download
   # the pre-built clang binary and not use the locally compiled binary from
   # the 'compile translation_unit clang tool' step.
   api.file.rmtree('llvm-build',
                   api.path['checkout'].join('third_party', 'llvm-build'))
 
   debug_path = api.path['checkout'].join('out', 'Debug')
   targets = bot_config.get('compile_targets', [])
   api.chromium.set_config('codesearch', BUILD_CONFIG='Debug')
+  api.chromium.ensure_goma()
   api.chromium.runhooks()
 
   result = GenerateCompilationDatabase(api, debug_path, targets, platform)
 
   try:
     api.chromium.compile(targets)
   except api.step.StepFailure as f: # pragma: no cover
     # Even if compilation fails, the Grok indexer may still be able to extract
     # (almost) all cross references. And the downside of failing on compile
     # error is that Codesearch gets stale.
@@ skipping 103 matching lines @@
     api.test(
         'full_%s_fail' % _sanitize_nonalpha('ChromiumOS Codesearch')) +
     api.step_data('generate compilation database for chromeos',
                   stdout=api.raw_io.output('some compilation data')) +
     api.step_data('generate compilation database for linux',
                   stdout=api.raw_io.output('some compilation data')) +
     api.step_data('run translation_unit clang tool', retcode=2) +
     api.properties.generic(buildername='ChromiumOS Codesearch',
                            mastername='chromium.infra.cron')
   )