Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2332253003: Corrects tests/language/initializing_formal_promotion_test.dart. (Closed)

Created:
4 years, 3 months ago by eernst
Modified:
4 years, 2 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch, Brian Wilkerson
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Corrects tests/language/initializing_formal_promotion_test.dart. Said test was created for scope rules that do not apply now, but it had never been updated. This CL moves the relevant expression to the scope where promotion can take place. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/1c7e4d83463a2732605d630f032bd61bd2acc856

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -11 lines) Patch
M tests/language/initializing_formal_promotion_test.dart View 2 chunks +6 lines, -10 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
Initializing formal parameters can receive type promotion, and this CL moves the type promoting construct ...
4 years, 3 months ago (2016-09-13 13:15:28 UTC) #2
Johnni Winther
lgtm
4 years, 3 months ago (2016-09-16 07:21:26 UTC) #3
eernst
4 years, 2 months ago (2016-10-05 14:06:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1c7e4d83463a2732605d630f032bd61bd2acc856 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698